Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error links in notebooks cannot be clicked in web extension #10287

Closed
rchiodo opened this issue Jun 2, 2022 · 4 comments · Fixed by #10471
Closed

Error links in notebooks cannot be clicked in web extension #10287

rchiodo opened this issue Jun 2, 2022 · 4 comments · Fixed by #10471
Assignees
@rchiodo
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2022

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Jun 2, 2022

Open in insiders.vscode.dev
Create an exception in a cell
Try clicking on a link

Nothing happens.
@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Jun 2, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 2, 2022
@greazer greazer added vscode-web and removed triage-needed Issue needs to be triaged labels Jun 6, 2022
@greazer greazer added this to the June 2022 milestone Jun 6, 2022
@kieferrm kieferrm mentioned this issue Jun 11, 2022
Closed
19 tasks
@rchiodo rchiodo self-assigned this Jun 15, 2022
@rchiodo rchiodo mentioned this issue Jun 16, 2022
Merged
@mjbvz mjbvz added verified Verification succeeded and removed verified Verification succeeded labels Jun 28, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 30, 2022 •
edited
Loading

Verification steps:

  1. Open insiders.vscode.dev
  2. Install latest prerelease jupyter extension
  3. On your local machine (assuming you have jupyter installed with at least IPython 8.0), run this from a python environment with jupyter
    jupyter notebook --no-browser --NotebookApp.allow_origin=*
  4. That should generate a URL. Copy the URL
  5. Go back to VS code and create a notebook
  6. Run the 'Jupyter: Specify Jupyter server for connections' command
  7. Pick 'Existing'
  8. Paste the URL from your local jupyter server
  9. In the notebook now enter a cell like so:
raise Exception('foo')
  1. That should generate an error output
  2. The error output should have clickable links
  3. Clicking a link should put focus back into the cell

@rebornix rebornix added the verified Verification succeeded label Jun 30, 2022
@rebornix
Copy link
Member

It doesn't seem to show links

image

I'm testing against v2022.6.1001831043 prerelease.

@rebornix rebornix added the verification-found Issue verification failed label Jun 30, 2022
@rebornix rebornix reopened this Jun 30, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 30, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 30, 2022

Sorry should have said you need to make sure you're using IPython 8.0 or higher.

@rchiodo rchiodo closed this as completed Jun 30, 2022
@rchiodo rchiodo removed verification-found Issue verification failed triage-needed Issue needs to be triaged labels Jun 30, 2022
@rchiodo
Copy link
Contributor Author

rchiodo commented Jun 30, 2022

IPython 7 won't parse the links at all.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rchiodo rchiodo

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Fix error links in web to work microsoft/vscode-jupyter
4 participants
@rebornix @greazer @mjbvz @rchiodo