Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI time #10399

Closed
rebornix opened this issue Jun 9, 2022 · 4 comments
Closed

Improve CI time #10399

rebornix opened this issue Jun 9, 2022 · 4 comments
Assignees
Labels
debt Code quality issues

Comments

@rebornix
Copy link
Member

rebornix commented Jun 9, 2022

This issue captured ideas brought up in offline discussions with @rchiodo for improving the testing experience in the repo, including faster CI time and tighter feedback loop for changes (locally)

  • Shared document/kernel for test suite when appropriate. We currently open and close document for every individual test, which will launch kernel for every single. The kernel startup contributes to main portion of our CI time. When document open/close and kernels state don't matter in a test suite, we could see how we can reuse the same document and kernel for faster testing.
  • A launch.json option (with properly tuned envs) to test non-conda tests locally. Currently the tests on a reasonably powerful machine takes too long and some of us rely on the CI for the test results.
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Jun 9, 2022
@github-actions github-actions bot added the triage-needed Issue needs to be triaged label Jun 9, 2022
@rchiodo rchiodo added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug triage-needed Issue needs to be triaged labels Jun 9, 2022
@rchiodo
Copy link
Contributor

rchiodo commented Jun 9, 2022

We could also work on improving

  • Compile time
  • Conda install time
  • Not install .NET/Julia for python tests

@rchiodo
Copy link
Contributor

rchiodo commented Jul 12, 2022

A launch.json option (with properly tuned envs) to test non-conda tests locally. Currently the tests on a reasonably powerful machine takes too long and some of us rely on the CI for the test results.

This option actually already exists. It's here:

"name": "Tests (Jupyter+Python Extension installed, *.vscode.test.ts)",

You might have to run this first:
https:/microsoft/vscode-jupyter/blob/main/src/test/datascience/setupTestEnvs.cmd

I'm going to update the launch.json to indicate that.

@DonJayamanne
Copy link
Contributor

Partial improvements made here #11867

@DonJayamanne
Copy link
Contributor

Closing this as majority of the work has been done (faster compilation, faser tests, etc)
If we can improve more, I think it can be done as a regular debt task.
This used to take 45 minutes or longer back a year ago, now its around 15 minutes

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

4 participants