Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore enabling Non-Python kernel auto complete #14672

Closed
6 of 10 tasks
rebornix opened this issue Nov 6, 2023 · 7 comments
Closed
6 of 10 tasks

Explore enabling Non-Python kernel auto complete #14672

rebornix opened this issue Nov 6, 2023 · 7 comments
Assignees
Labels
feature-request Request for new features or functionality notebook-intellisense Intellisense & other language features in notebook cells for any language

Comments

@rebornix
Copy link
Member

rebornix commented Nov 6, 2023

We might already have issues open for this request but I couldn't find that yet.

Notes:

  • Feature will be behind an experiment
  • Experiment will be rolled out to all insiders
  • We will need to ensure completion requests to the kernel complete quickly, so as to prevent slowing down the kernel
  • Python kernel completion cannot be disabled (it is on by default)
  • Python kernel completion does not support displaying documentation (resolveCompletionItem not implemeneted)
  • Kernel completions will be enabled by default
  • Configurable non-python kernel completion trigger characters
  • Setting to run off non-python kernel completions
  • Merge Python and non-python kernel completions into the same settings (turn off and trigger characters)
    This will need to be done after the experiment, once were comfortable enabling this new feature (non-python kernels) for all
  • Leave experiment for at least 2 months.
@rebornix rebornix added the feature-request Request for new features or functionality label Nov 6, 2023
@rebornix rebornix added this to the November 2023 milestone Nov 6, 2023
@Philonoist
Copy link

Yes please! As a concrete example, I would like to use Rust jupyter kernel (https:/evcxr/evcxr/blob/main/evcxr_jupyter/README.md)
with completions. (rust-analyzer lsp integration exists both in plain jupyter lab, and in vscode).
If I can help here, let me know.

@maxandersen
Copy link

I see the option Enable Kernel Completions but not seeing any requests for it to the kernel.

how does one trigger it?

@DonJayamanne
Copy link
Contributor

t not seeing any requests for it to the kernel.

@maxandersen What version of VS Code and Jupyter extension are you using?
This should be enabled by default in VS Code Insiders and the Pre-releaase version of the Jupyter extension (I think i mentioned that in a previous comment)

how does one trigger it?

This gets triggered via the characters . @ # in Java.
You can customize these trigger characters via the setting jupyter.completionTriggerCharacters

@maxandersen
Copy link

I'm running latest vscode insiders (Version: 1.85.0-insider (Universal)
Commit: 055458feab40fc308fc6d70b185068138c8cf8eb
Date: 2023-11-27T05:36:15.984Z (1 day ago) and the pre-release of jupyter extension v2023.11.1003331000.

I'll try it out some more and see whats going on.

@DonJayamanne
Copy link
Contributor

Please use the keys ctrl+space to force completions to show up
Please could you enable logging as follows:

  • Open settings & go into Jupyter->Logging
  • Change the value to verbose
  • Reload VS Code,
  • Attempt to repro the issue & then copy the output from the Jupyter output panel.

@maxandersen
Copy link

@DonJayamanne got it working. not sure what made the difference. I did say yes to install python and java extension this time when starting up.

can it be that the python extension matching runtime needs installing for completion to work ? it seems weird as i was executing code via the kernel without following those popup "recommendations/suggestions" on what to install.

@DonJayamanne DonJayamanne modified the milestones: November 2023, December 2023 Nov 29, 2023
@DonJayamanne DonJayamanne added notebook-intellisense Intellisense & other language features in notebook cells for any language and removed on-testplan labels Dec 5, 2023
@joaomoreno joaomoreno removed this from the December 2023 milestone Dec 11, 2023
@DonJayamanne
Copy link
Contributor

This has been completed in the latest version of Jupyter extension.
See follow settings
Screenshot 2024-04-03 at 07 54 35

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook-intellisense Intellisense & other language features in notebook cells for any language
Projects
None yet
Development

No branches or pull requests

5 participants