Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize using vscode-loc #9676

Closed
DonJayamanne opened this issue Apr 12, 2022 · 3 comments · Fixed by #10361
Closed

Localize using vscode-loc #9676

DonJayamanne opened this issue Apr 12, 2022 · 3 comments · Fixed by #10361
Assignees
Labels
debt Code quality issues

Comments

@DonJayamanne
Copy link
Contributor

Looks like the Python extension is finally adopting the vscode-loc package to localize strings in the exension.
We might want to look into this.

@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Apr 12, 2022
@rchiodo
Copy link
Contributor

rchiodo commented May 5, 2022

See the directions that Tyler has:
https://gist.github.com/TylerLeonhardt/83abd380686ac1321b01552a5b236bad

@DonJayamanne
Copy link
Contributor Author

We'd need to see how this would work with webviews.
@TylerLeonhardt do you have any idea whether this is possible today? or of any work arounds?

@TylerLeonhardt
Copy link
Member

Webviews aren't supported today because you need a file system for localization at this time.

The best you can do today is have your strings on the extension host side and then send them to the webview.

This will get better over time

@sadasant sadasant self-assigned this Jun 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants