Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable completions exp for insiders/pre-release #14775

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Enable completions exp for insiders/pre-release #14775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/platform/common/experiments/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { inject, injectable, named } from 'inversify';
import { Memento } from 'vscode';
import { getExperimentationService, IExperimentationService, TargetPopulation } from 'vscode-tas-client';
import { IApplicationEnvironment, IWorkspaceService } from '../application/types';
import { JVSC_EXTENSION_ID } from '../constants';
import { JVSC_EXTENSION_ID, isPreReleaseVersion } from '../constants';
import { traceInfo, traceVerbose } from '../../logging';
import { GLOBAL_MEMENTO, IConfigurationService, IExperimentService, IJupyterSettings, IMemento } from '../types';
import { Experiments } from '../utils/localize';
Expand Down Expand Up @@ -115,6 +115,14 @@ export class ExperimentService implements IExperimentService {
return true;
}

// Enable the kernel completions experiment for all insider users
if (
experiment === ExperimentGroups.KernelCompletions &&
(this.appEnvironment.channel === 'insiders' || isPreReleaseVersion())
) {
return true;
}

// If getTreatmentVariable returns undefined,
// it means that the value for this experiment was not found on the server.
const treatmentVariable = this.experimentationService.getTreatmentVariable(
Expand Down Expand Up @@ -174,6 +182,7 @@ export class ExperimentService implements IExperimentService {
}

const optedIntoExperiments = new Set(this._optInto);
const enabledExperiments = new Set<string>();

// Log experiments that users manually opt out, these are experiments which are added using the exp framework.
this._optOutFrom
Expand All @@ -186,9 +195,18 @@ export class ExperimentService implements IExperimentService {
this._optInto
.filter((exp) => exp !== 'All')
.forEach((exp) => {
enabledExperiments.add(exp);
traceInfo(Experiments.inGroup(exp));
});

if (
experimentsDisabled &&
!enabledExperiments.has(ExperimentGroups.KernelCompletions) &&
(this.appEnvironment.channel === 'insiders' || isPreReleaseVersion())
) {
traceInfo(Experiments.inGroup(ExperimentGroups.KernelCompletions));
}

if (!experimentsDisabled) {
// Log experiments that users are added to by the exp framework
this.getFeatures().forEach((exp) => {
Expand Down
Loading