Use LF instead of CRLF, when run against kernel #7659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
requested review from
DavidKutu,
IanMatthewHuff,
joyceerhl and
rchiodo
rchiodo
approved these changes
Sep 24, 2021
| @@ -498,7 +498,7 @@ export class JupyterNotebookBase implements INotebook { | |||
| ? this.session.requestExecute( | |||
| { | |||
| // Remove the cell marker if we have one. | |||
| code: cellMatcher.stripFirstMarker(code), | |||
| code: cellMatcher.stripFirstMarker(code.replace(/\r\n/g, '\n')), | |||
There was a problem hiding this comment.
These usages look like the only three usages of session.requestExecute. So should this replace instead go into BaseJupyterSession.requestExecute? That would put it in only one place, and prevent someone else from adding a new usage of requestExecute that re-creates this issue.
There was a problem hiding this comment.
I don't want to refactor the code, ideally we should have just one.
When the old Jupyter layer goes away we'll automatically have just one.
The other two will be in kernel stuff & i'd like to remove the executeSilently to go through kernel as well (but don't want to introduce a refactoring now)
Hopefully we'll get to some of that in debt week.
IanMatthewHuff
approved these changes
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #4576
I need to test this on a windows machine, will start on getting the windows pc up.