Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support llmGenerated property on CodeAction #1557

Merged
merged 8 commits into from
Sep 26, 2024

Conversation

StellaHuang95
Copy link
Contributor

Addresses #1555

  • Added llmGeneratedSupport to CodeActionClientCapabilities.
  • Added llmGenerated to CodeAction.
  • Added conversion logics in protocolConverter and codeConverter.
  • Added the proposed api to the enabledApiProposals in package.json and the corresponding .d.ts file.

@dbaeumer
Copy link
Member

Looking at the implementation now another boolean here feels wrong. I think we should follow the same approach as we did with other literals and add a tags field with CodeActionTag (like SymbolTag or CompletionItemTag). This make it homogenous with approaches we use somewhere else.

types/src/main.ts Outdated Show resolved Hide resolved
types/src/main.ts Outdated Show resolved Hide resolved
types/src/main.ts Outdated Show resolved Hide resolved
Copy link
Member

@dbaeumer dbaeumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Only some minor wording tweaks.

@dbaeumer
Copy link
Member

Let's wait until we have the spec right and then we finish up the coding. Is that OK for you?

@StellaHuang95
Copy link
Contributor Author

Let's wait until we have the spec right and then we finish up the coding. Is that OK for you?

Sure, I've updated the spec. Let me know if it looks good:)

@StellaHuang95
Copy link
Contributor Author

I've added the tagSupport client capability, let me know if there's anything else. Thanks!

@karthiknadig
Copy link
Member

karthiknadig commented Sep 24, 2024

As far as I can tell this is enabled for the extension (in product.json). Marking the extension side verified (microsoft/vscode-python#24068)

@dbaeumer
Copy link
Member

@StellaHuang95 nice work!

@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 25, 2024
@dbaeumer dbaeumer merged commit 62b3198 into microsoft:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants