Changes to client-side azure resource filtering #18274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benjin
requested review from
kburtram,
aasimkhan30,
cssuh,
caohai,
laurennat and
lewis-sanchez
as code owners
PR Changes
|
aasimkhan30
approved these changes
Oct 18, 2024
caohai
reviewed
Oct 18, 2024
Benjin
added a commit
that referenced
this pull request
Oct 18, 2024
* slight refactoring * swapping azure logic to client-side filtering
kburtram
pushed a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #18240
I found that I was getting an error message saying that the resource filter argument I was passing for server-side processing was invalid... for some subscriptions, but not all (or even most). Curiously, it was consistently the same subscriptions that would return the error, and I didn't notice any pattern to it. My mind went to permissions, but the query for all resources under that sub is consistently working fine for all subs so that doesn't make sense.
In any case, I switched to doing the filtering client-side in order to solve the issue.