Move onDidChangeActiveTextEditor event registration behind feature flag #18283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caohai
requested review from
kburtram,
aasimkhan30,
cssuh,
laurennat,
lewis-sanchez and
Benjin
as code owners
cssuh
approved these changes
Oct 18, 2024
PR Changes
|
Benjin
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #18285
In #18192, the
onDidChangeActiveTextEditorevent handler was setup without checking the rich UI feature flag. This causes an error log in the dev console every time the user switches the editor tab if they don't have the rich UI flag turned on.Note this does not break other features, just output error message to the dev console.