Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New "Create PR" design #4933

Closed
wants to merge 2 commits into from
Closed

New "Create PR" design #4933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
366d3d4
pr: Remove title/description labels and tweak placeholders
hbons Jun 20, 2023
7531993
pr: Tweak section titles
hbons Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/integrations/gitlens/gitlensImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class GitLensIntegration implements Disposable {
api.registerActionRunner('createPullRequest', {
partnerId: 'ghpr',
name: 'GitHub Pull Requests and Issues',
label: 'Create Pull Request',
label: 'Create',
run: function (context: CreatePullRequestActionContext) {
// For now only work with branches that aren't remote
if (context.branch.isRemote) {
Expand Down
6 changes: 2 additions & 4 deletions webviews/createPullRequestViewNew/app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ export function main() {
: null}

<div className='wrapper'>
<label className='input-label' htmlFor='title'>Title</label>
<input
id='title'
type='text'
Expand All @@ -180,7 +179,7 @@ export function main() {
className={params.showTitleValidationError ? 'input-error' : ''}
aria-invalid={!!params.showTitleValidationError}
aria-describedby={params.showTitleValidationError ? 'title-error' : ''}
placeholder='Pull Request Title'
placeholder='Title'
value={params.pendingTitle}
required
onChange={(e) => updateTitle(e.currentTarget.value)}
Expand All @@ -190,11 +189,10 @@ export function main() {
</div>

<div className='wrapper'>
<label className='input-label' htmlFor='description'>Description</label>
<textarea
id='description'
name='description'
placeholder='Pull Request Description'
placeholder='Description'
value={params.pendingDescription}
required
onChange={(e) => ctx.updateState({ pendingDescription: e.currentTarget.value })}
Expand Down