Refactor Native REPL code #23550
Merged
Refactor Native REPL code #23550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonykim1
added
debt
amunger
reviewed
Jun 6, 2024
amunger
reviewed
Jun 6, 2024
| activeEditor.selection = new Selection(newPosition, newPosition); | ||
|
|
||
| activeEditor.edit((editBuilder) => { | ||
| editBuilder.insert(newPosition, '\n'); |
There was a problem hiding this comment.
at some point, we need to figure out how to get the indentation correct as well.
There was a problem hiding this comment.
will ask how to pass newline character to monaco editor.
amunger
reviewed
Jun 6, 2024
amunger
reviewed
Jun 6, 2024
anthonykim1
commented
Jun 17, 2024
amunger
reviewed
Jun 18, 2024
amunger
reviewed
Jun 18, 2024
amunger
reviewed
Jun 18, 2024
amunger
reviewed
Jun 18, 2024
Co-authored-by: Aaron Munger <[email protected]>
amunger
approved these changes
Jun 18, 2024
DonJayamanne
pushed a commit
that referenced
this pull request
Jun 24, 2024
Refactor Native REPL code. Resolves: #23632 --------- Co-authored-by: Aaron Munger <[email protected]>
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jun 28, 2024
Refactor Native REPL code. Resolves: microsoft#23632 --------- Co-authored-by: Aaron Munger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Native REPL code.
Resolves: #23632