Updates to use new Python locator Api #23832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
added
no-changelog
DonJayamanne
commented
Jul 18, 2024
| @@ -306,6 +345,8 @@ class NativeGlobalPythonFinderImpl extends DisposableBase implements NativePytho | |||
| notifyUponCompletion(); | |||
| }; | |||
|
|
|||
| // Assumption is server will ensure there's only one refresh at a time. | |||
| // Perhaps we should have a request Id or the like to map the results back to the `refresh` request. | |||
There was a problem hiding this comment.
Will review the API tomorrow/later (after finishing other work), but leaving this as is for now
@karthiknadig /cc
DonJayamanne
commented
Jul 18, 2024
| // Lowercase for purposes of comparison (safe). | ||
| executablesFoundByNativeLocator.add(data.executable.toLowerCase()); | ||
| } else if (data.prefix) { | ||
| if (isNativeInfoEnvironment(data)) { |
There was a problem hiding this comment.
@karthiknadig none of this code gets executed in the main branch anymore,
We can discuss that offline and fix that in a sepearate PR
But we'll need to get that done before the release
aeschli
approved these changes
Jul 18, 2024
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.