Update Pylance settings telemetry property list to match code #23841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debonte
added
no-changelog
karthiknadig
approved these changes
Jul 20, 2024
rchiodo
approved these changes
Jul 22, 2024
|
@debonte Should this be merged for this iteration? |
|
Erik's OOF today. I'd say yes. We already shipped this telemetry. |
Actually the associated Pylance PR hasn't been merged yet. Feel free to do that if you're comfortable with it. |
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to add the
disableTaggedHintsproperty to the settings event and noticed that several other properties were also missing. Added them. Also fixed alphabetical sorting.