Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect pipenv by looking for Pipfile, not pipfile #994

Merged
merged 1 commit into from
Mar 9, 2018

Commits on Mar 9, 2018

  1. Detect pipenv by looking for Pipfile, not pipfile

    On platforms with case-sensitive filesystems, like Linux, these are not
    equivalent. pipenv documents that the file should be called Pipfile[0]
    and `Pipfile.find()` only finds files matching this exact case[1].
    
    As a result, even if `pipenv --venv` in `cwd` would return success, it
    will never be run on Linux, and Code never detects the pipenv. (You can
    work around this with `touch pipfile`.) With this change, it's detected
    successfully. I believe there's no need to add a backwards-compatibility
    check for the old case, because on platforms where the old, incorrect
    check worked, so will the new, correct one.
    
    [0] https://docs.pipenv.org/basics/#example-pipfile-pipfile-lock
    [1] https:/pypa/pipfile/blob/5acb9ac7/pipfile/api.py#L76-L85
    wjt committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    e9b3f0e View commit details
    Browse the repository at this point in the history