-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unpublish should require more confirmation than just a "y" #782
Comments
That sucks, I'm so sorry you went through this. Have you reached out to the Marketplace team to restore your history? Would you like me to give you a connection? They might be able to do something about it. cc @isidorn Your suggestion makes sense. But given that extension authors can unpublish via https://marketplace.visualstudio.com/manage why don't we simply remove this functionality from vsce instead? |
That would work too. Personally I don't see any use case for automating the (presumably very infrequent) unpublish action, so it doesn't seem particularly useful to include in this command-line application. The only use case I can come up with for automatically unpublishing an extension is the anti-abuse case, which presumably would be done via some internal Microsoft tool. |
Fixed in 2.14.0. |
Last night I accidentally made a critical mistake that destroyed 7-8 years of version history, installation count and reviews for an extension that I maintain. I was almost in tears for having destroyed so much work with a single keypress and still feel terrible today. It was my mistake and I take full responsibility, but I feel like the
vsce
tool didn't try hard enough to stop me from making the mistake. My workflow was this:vsce publish
to publish a new versionvsce unpublish
to revert my change and reflexively hit ''y" because I have been trained to hit "y" a bunch of times forvsce
to do anythingThis blew away all the history of
auiworks.amvim
from the Marketplace. I immediately realized my mistake and tried to Ctrl-C out of it, but it was too late. For such an incredibly destructive operation, it feels like there should be more confirmation than just the short prompt and standard yes/no choice found for much more trivial confirmations in the rest of the app.I propose that
vsce
follows the example of Github, where even just to delete a local fork of a repository you need to type the entire repository name out. I am quite certain that ifvsce unpublish
had prompted me to type the qualified name of the extension before going ahead with the removal, I would have realized my mistake and canceled out of it.Related to microsoft/vsmarketplace#235
The text was updated successfully, but these errors were encountered: