Allow packaging extension without a publisher #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeschli
previously approved these changes
Aug 22, 2024
Tyriar
previously requested changes
Aug 22, 2024
src/package.ts
Outdated
Comment on lines
1271
to
1275
|
|
||
| // allow users to package an extension without a publisher for testing reasons | ||
| if (manifest.publisher) { | ||
| validatePublisher(manifest.publisher); | ||
| } |
There was a problem hiding this comment.
Something seems off with the types here? If manifest.publisher does not have | undefined it should, if it does then validatePublisher should support validating an undefined publisher?
There was a problem hiding this comment.
You are totally right, it's weird because we have different requirements for packaging and publishing but the types are only ensured for publishing currently. I'll create different types and validation for both requirement cases, possibly more debt work to come...
sandy081
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the validation of the publisher field in the package manifest. Previously, the validation was triggered even if no publisher was set. With this change, the validation is only performed if a publisher is specified, allowing users to package an extension without a publisher for testing purposes.
fixes #1029