Icons missing from extension trees with resource uris (#152039)

Fixes #152036
microsoft · Jun 14, 2022 · 30d9c6c · 30d9c6c · mkexchange · Jun 26, 2022
1 parent ab220b2
commit 30d9c6c
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/vs/workbench/browser/parts/views/treeView.ts b/src/vs/workbench/browser/parts/views/treeView.ts
@@ -1084,7 +1084,7 @@ class TreeRenderer extends Disposable implements ITreeRenderer<ITreeItem, FuzzyS
  private shouldHideResourceLabelIcon(iconUrl: URI | undefined, icon: ThemeIcon | undefined): boolean {
  // We always hide the resource label in favor of the iconUrl when it's provided.
  // When `ThemeIcon` is provided, we hide the resource label icon in favor of it only if it's a not a file icon.
- return !!iconUrl || !this.isFileKindThemeIcon(icon);
+ return (!!iconUrl || (!!icon && !this.isFileKindThemeIcon(icon)));
  }
 
  private shouldShowThemeIcon(hasResource: boolean, icon: ThemeIcon | undefined): icon is ThemeIcon {