Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run menu does not remember launch configuration from settings.json #100451

Closed
bersbersbers opened this issue Jun 18, 2020 · 6 comments
Closed

Run menu does not remember launch configuration from settings.json #100451

bersbersbers opened this issue Jun 18, 2020 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@bersbersbers
Copy link

bersbersbers commented Jun 18, 2020

  • VSCode Version: 1.46.0
  • OS Version: Win 10 2004

Steps to Reproduce:

  1. Have "Python: Current File" launch config in your user settings.json
  2. Have project/.vscode/launch.json with additional launch configs.
  3. Use a multi-root workspace (not sure this is required)
  4. Select "Python: Current File (user settings)"
  5. Reload
  6. Note that the first workspace launch config is selected.

This reads similar to #96293, but I don't even know what a dynamic launch configuration is, so I doubt I am using one. My user-settings one is almost certainly non-dynamic:

    "launch": {
        "configurations": [
            {
                "presentation": {
                    "group": "00 Python",
                    "order": 0,
                },
                "name": "Python: Current File",
                "type": "python",
                "request": "launch",
                "program": "${file}",
                "justMyCode": false,
                "subProcess": true,
                "internalConsoleOptions": "openOnSessionStart",
                "console": "internalConsole",
            },
        ],
    },

Does this issue occur when all extensions are disabled?: No (need SSH remote)

@isidorn isidorn added the info-needed Issue requires more information from poster label Jun 18, 2020
@isidorn
Copy link
Contributor

isidorn commented Jun 18, 2020

Thanks for filling this issue. Can you reproduce using Visual Studio Code Insiders https://code.visualstudio.com/insiders/

@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 18, 2020
@bersbersbers
Copy link
Author

Thanks for filling this issue. Can you reproduce using Visual Studio Code Insiders https://code.visualstudio.com/insiders/

Yes, just tested commit id b9d7ec9.

@isidorn
Copy link
Contributor

isidorn commented Jun 22, 2020

Thanks for trying vscode insiders.
Looks like an issue with how we preserve configuration names from user settings.
Code pointer if someone would like to investigate more https:/microsoft/vscode/blob/de1f4a6cbf942096567408e0ac82381b499445c3/src/vs/workbench/contrib/debug/browser/debugConfigurationManager.ts#L86

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Jun 22, 2020
@isidorn isidorn added this to the Backlog milestone Jun 22, 2020
@bersbersbers
Copy link
Author

bersbersbers commented Jul 12, 2020

If some starts working in this, I guess that problem 2 of #90216 is related - maybe both can be fixed together.

Second problem

While having launch config A selected in "Run and Debug", changing any configuration (either A in settings.json or B in .vscode\launch.json), results in configuration B being selected in "Run and Debug". (Note that it is not enough to simply re-save these files - you actually have to make a meaningful, non-whitespace edit within a launch configuration to trigger refresh of the launch config selection. It does not require visible a change of name/order/..., though.)

@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Nov 2, 2020
@bersbersbers
Copy link
Author

Sad to see that - it is beyond me why this issue has been closed. It has the exact same description and user impact as #96293 (just replace "dynamic" by "user"), which has recently been fixed. This includes the same repeated annoyance every time one presses F5 to start debugging after starting VS Code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants
@isidorn @bersbersbers and others