Remove some deprecated code in ./src/vs/base

[LeuisKen]

I find that following methods are deprecated:

7 results - 2 files

src/vs/base/browser/dom.ts:
  74  };
  75  
  76: /** @deprecated ES6 - use classList*/
  77  export function hasClass(node: HTMLElement | SVGElement, className: string): boolean { return _classList.hasClass(node, className); }
  78: /** @deprecated ES6 - use classList*/
  79  export function addClass(node: HTMLElement | SVGElement, className: string): void { return _classList.addClass(node, className); }
  80: /** @deprecated ES6 - use classList*/
  81  export function addClasses(node: HTMLElement | SVGElement, ...classNames: string[]): void { return _classList.addClasses(node, ...classNames); }
  82: /** @deprecated ES6 - use classList*/
  83  export function removeClass(node: HTMLElement | SVGElement, className: string): void { return _classList.removeClass(node, className); }
  84: /** @deprecated ES6 - use classList*/
  85  export function removeClasses(node: HTMLElement | SVGElement, ...classNames: string[]): void { return _classList.removeClasses(node, ...classNames); }
  86: /** @deprecated ES6 - use classList*/
  87  export function toggleClass(node: HTMLElement | SVGElement, className: string, shouldHaveIt?: boolean): void { return _classList.toggleClass(node, className, shouldHaveIt); }
  88  

src/vs/base/common/strings.ts:
  15  
  16  /**
  17:  * @deprecated ES6: use `String.padStart`
  18   */
  19  export function pad(n: number, l: number, char: string = '0'): string {

I'd like to send a pull request to remove these deprecated methods and refactor all usages if you want.

[rebornix]

Starting from @mjbvz , not sure where the deprecation information are from.

[jrieken]

I'd like to send a pull request to remove these deprecated methods

👎 We do not accept pull requests like that

[jrieken]

This is driven from .vscode/searches/es6.code-search and each and every user of the listed functions needs to become active.

[jrieken]

The classList usage is usually a big change, the others should be small... Starting with @joaomoreno, please pass it on to the next person

[joaomoreno]

@jrieken I am out this month... sorry.

[mjbvz]

Remaining:

src/vs/base/common/strings.ts

• pad
• startsWith
• endsWith
• repeat

src/vs/base/common/objects.ts

•  assign

src/vs/base/browser/dom.ts

• removeNode
• hasClass and friends

src/vs/base/common/arrays.ts

• first
• find

[isidorn]

I have replaced my usages of the deprecated code. I believe I have cought all places, however if some remain feel free to ping me.
Assigning this to @joaomoreno since I saw a lot of usages in our widgets, though feel free to pass it on to the next person.

[joaomoreno]

Here's a useful find/replace input pair, for text based refactoring:

(add|remove|toggle)Class\(([^,]+), 
$2.classList.$1(

[joaomoreno]

The unfortunate choice of having multiple class names on a single string Codicon.classNames: string and having DOM.addClass support that is the hardest problem here. Going with simple refactoring, powered by TypeScript, you immediately hit very bad things:

[mjbvz]

Remaining (all under dom.ts):

• addClass
• addClasses
• removeClasses
• toggleClass

@joaomoreno Assigning you to start. Please reassign to correct owners for this

[joaomoreno]

• Terminal @Tyriar
• Webview @mjbvz
• Scrollbar @alexdima
• Lightbulb Widget @aeschli
• Workbench Theme Service @aeschli

[jrieken]

oh, wow actually done

[jrieken]

👏 and thanks everyone involved here