Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include select service flow into the configure command and turn on sync wizard #104496

Closed
Tyriar opened this issue Aug 12, 2020 · 7 comments · Fixed by #106953
Closed

Include select service flow into the configure command and turn on sync wizard #104496

Tyriar opened this issue Aug 12, 2020 · 7 comments · Fixed by #106953
Assignees
Labels
feature-request Request for new features or functionality settings-sync ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 12, 2020

In order to make the select service more discoverable and to help the user understand that it's a thing, we should add it to the flow for turning on settings sync for Insiders only:

Step 1:

image

Step 2:

image

Step 3: Account selection

We should also roll the select service into the Settings Sync: Configure... command and remove the extra select service command.

@Tyriar Tyriar added this to the August 2020 milestone Aug 12, 2020
@sandy081 sandy081 added feature-request Request for new features or functionality ux User experience issues labels Aug 17, 2020
@sandy081
Copy link
Member

TBH I am not a big fan of adding too many steps to the flow, might be a bad user experience. It would be nice if all configuration is available in single step. For eg., It would be nice, if we can show the option to use stable service in the first step itself.

@Tyriar
Copy link
Member Author

Tyriar commented Aug 26, 2020

This will be a much bigger problem when syncing doesn't work as expected for users of Codespaces. The proposal is a way to allow desktop Insiders users to discover and fix the problem themselves instead of reporting issues to us and Codespaces.

@sandy081 sandy081 reopened this Aug 26, 2020
@sandy081
Copy link
Member

Sorry, attached the fix to the wrong issue.

@sandy081
Copy link
Member

sandy081 commented Sep 17, 2020

Insiders user can now select the settings sync service while turning on sync.

Kapture 2020-09-17 at 20 28 00

To sync with another service, turn off, turn on using another service.

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Sep 28, 2020
@sandy081
Copy link
Member

To verify:

  • Open VS Code insiders
  • Turn on Settings Sync (if it is already turned on, turn it off and turn it on)
  • Make sure you are asked to use insiders or stable settings sync service while turning on (during turn on flow)
  • Select the service and make sure that data is synced correctly (You can use your VS Code stable client to verify sync if you are using stable settings sync service)

@roblourens
Copy link
Member

I remember seeing this in the past but I don't see the service selection now. I see the configuration step then the account picker and that's it...

@roblourens roblourens reopened this Sep 30, 2020
@sandy081
Copy link
Member

I still see it. Please check if you have configured settings sync store in settings, if so remove it and try.

@roblourens roblourens added the verified Verification succeeded label Sep 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality settings-sync ux User experience issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@roblourens @Tyriar @sandy081 and others