Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trusted Types compatibility: use DOM API for creating HTML elements instead of string concatenation in inspectEditorTokens.ts #105509

Closed
annkamsk opened this issue Aug 27, 2020 · 2 comments · Fixed by #105510
Closed

Trusted Types compatibility: use DOM API for creating HTML elements instead of string concatenation in inspectEditorTokens.ts #105509

annkamsk opened this issue Aug 27, 2020 · 2 comments · Fixed by #105510
Assignees
@jrieken @aeschli
Labels
engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2020

Comments

@annkamsk
Copy link
Contributor

The next step in resolving #103699. Simirarly to #105501, it aims to replace construction of HTML elements by string concatenation in src/vs/editor/standalone/browser/inspectTokens.ts file. The code contains mainly a table construction by concatenating strings of <tr><td class=”foo”>foobar</td><td class=”bar”>barfoo</td></tr>. The goal is to replace them all with dom.ts#$ function calls.
@annkamsk annkamsk mentioned this issue Aug 27, 2020
Merged
@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Aug 28, 2020
@jrieken jrieken added this to the August 2020 milestone Aug 28, 2020
@aeschli aeschli added feature-request Request for new features or functionality verified Verification succeeded labels Aug 31, 2020
@aeschli
Copy link
Contributor

aeschli commented Aug 31, 2020

I verified by running the monaco editor from source and testing the inspect token hover

@aeschli aeschli added the verification-needed Verification of issue is requested label Aug 31, 2020
@aeschli
Copy link
Contributor

aeschli commented Aug 31, 2020

To verify, open the Inspect Editor Tokens and Scope hover and verify it looks all proper.

@aeschli aeschli removed the verification-needed Verification of issue is requested label Aug 31, 2020
@RMacfarlane RMacfarlane added verification-needed Verification of issue is requested and removed verified Verification succeeded labels Sep 1, 2020
@mjbvz mjbvz added the verified Verification succeeded label Sep 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@aeschli aeschli

Labels
engineering VS Code - Build / issue tracking / etc. feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

Successfully merging a pull request may close this issue.

Create HTML with dom.ts#$ function calls instead of string concatenation annkamsk/vscode
6 participants
@jrieken @RMacfarlane @aeschli @mjbvz @annkamsk and others