Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auto attach toggle workspace settings by default #105883

Closed
connor4312 opened this issue Sep 1, 2020 · 1 comment · Fixed by #106521
Closed

Make auto attach toggle workspace settings by default #105883

connor4312 opened this issue Sep 1, 2020 · 1 comment · Fixed by #106521
Assignees
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue

Comments

@connor4312
Copy link
Member

Are you setting auto attach to "on" in your user settings? Note that the Toggle Auto Attach command will persist in the workspace setting by default.

Oh my. I find this a bit confusing. So if I manualy first set it in user settings you will always write it there, otherwise you would do this in the workspace settings - making the whole repository dirty. I am not a fan of automatic writing in workspace settings...

Originally posted by @isidorn in #105771 (comment)

@connor4312
Copy link
Member Author

connor4312 commented Sep 1, 2020

Or, we can remove the command since quick access is no longer as necessary microsoft/vscode-js-debug#732 (comment)

@connor4312 connor4312 added the polish Cleanup and polish issue label Sep 1, 2020
@connor4312 connor4312 added this to the September 2020 milestone Sep 1, 2020
@connor4312 connor4312 self-assigned this Sep 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@connor4312 and others