Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support persisting splits in reconnected terminals across window reloads #110107

Closed
Tyriar opened this issue Nov 6, 2020 · 2 comments
Closed
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality remote Remote system operations issues terminal Integrated terminal issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 6, 2020

Currently when remotes reconnect terminals the split terminals get flattened into their own terminals. This is mainly an issue of how we want to persist that knowledge across sessions and make sure the remote agent stores it (eg. splitIndex: number may be enough). Note also that split terminals are naturally smaller so they have non-standard dimensions, not sure we need to do anything special to handle dimensions differently as resize events are recorded.

Ideally there may need to be some logic/checks to ensure split terminals get adopted together so they cannot be split up. This will probably involve the introduction of the terminal tab idea on the server.

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues remote Remote system operations issues labels Nov 6, 2020
@Tyriar Tyriar added this to the Backlog milestone Nov 6, 2020
@Tyriar Tyriar self-assigned this Nov 6, 2020
@bpasero
Copy link
Member

bpasero commented Nov 7, 2020

Isn't this #109244 ?

@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality remote Remote system operations issues terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @Tyriar and others