Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env var relaunch is distracting #118066

Closed
Tyriar opened this issue Mar 3, 2021 · 1 comment · Fixed by #119092
Closed

Env var relaunch is distracting #118066

Tyriar opened this issue Mar 3, 2021 · 1 comment · Fixed by #119092
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues
Milestone
March 2021

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 3, 2021

When opening a Codespace for example there is a flicker in the terminal when it relaunches after the git extension contributes environment variables. Proposal:

  • Relaunch but don't touch the xterm.js instance
  • After 3 seconds or when focus or any input happens, diff the old terminal's data events with the new terminal's data events and if they're identical, do nothing, otherwise reset the terminal and write the new terminal's events
@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels Mar 3, 2021
@Tyriar Tyriar added this to the March 2021 milestone Mar 3, 2021
@kieferrm kieferrm mentioned this issue Mar 6, 2021
Closed
76 tasks
@Tyriar
Copy link
Member Author

Tyriar commented Mar 9, 2021

Might be able to tackle this debt task at the same time to make process reuse less bug prone #100709

@Tyriar Tyriar mentioned this issue Mar 11, 2021
Closed
This was referenced Mar 16, 2021
Merged
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal Integrated terminal issues
Projects
None yet
Milestone
March 2021
Development

Successfully merging a pull request may close this issue.

Seamless terminal relaunch microsoft/vscode
3 participants
@Tyriar @meganrogge and others