Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard me to ownership of our quick picker code #118586

Closed
TylerLeonhardt opened this issue Mar 9, 2021 · 4 comments
Closed

Onboard me to ownership of our quick picker code #118586

TylerLeonhardt opened this issue Mar 9, 2021 · 4 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc.
Milestone

Comments

@TylerLeonhardt
Copy link
Member

This means several things:

  • The actual quick pick widget (currently owned by @bpasero)
  • The quick pick API (currently owned by @chrmarti)
  • Cmd+P file search (currently owned by @roblourens)

I will work with each of these individuals to become more familiar with those parts... potentially work on any bugs/small features to get acclimated... and then update any ownership docs/bots to reflect the change.

@TylerLeonhardt TylerLeonhardt self-assigned this Mar 9, 2021
@TylerLeonhardt
Copy link
Member Author

This will probably span multiple milestones.

@TylerLeonhardt TylerLeonhardt added this to the April 2021 milestone Mar 9, 2021
@TylerLeonhardt TylerLeonhardt added the engineering VS Code - Build / issue tracking / etc. label Mar 9, 2021
@TylerLeonhardt TylerLeonhardt modified the milestones: April 2021, March 2021 Mar 9, 2021
@bpasero
Copy link
Member

bpasero commented Mar 10, 2021

@TylerLeonhardt fyi the quick pick widget is owned by @chrmarti . I am the author of the related quick access providers:

registerQuickAccessProvider(provider: IQuickAccessProviderDescriptor): IDisposable {

E.g. the actual pickers for things like file search, symbol search, etc. Anything that can be found here:

image

@TylerLeonhardt
Copy link
Member Author

This will be closed in May 😄

@TylerLeonhardt
Copy link
Member Author

I guess I can be called the owner :)

@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

No branches or pull requests

2 participants