Make Find in Selection not enabled by default

[ghost]

• VSCode Version: Code 1.5.2 (66f37fd, 2016-09-12T13:05:12.065Z)
• OS Version: Darwin x64 15.6.0

Steps to Reproduce:

[ramya-rao-a]

@Turash Can you provide more details on which search are you referring to?

• Search in a file
• Search across files
• Quick open
• Find all references

There are different search features

[bpasero]

Needs more info.

[ghost]

Hi, It does not happen every time. Sometimes. I will paste right away when I experience.

[ghost]

[chrmarti]

The screenshot shows a text search within a file. The file shows several occurrences of the text "marker" while the search box searching for "marking" says "No results".

@Turash:

• Does the problem always occur with this file and the search for "marker"?
• Does the problem go away when you close and reopen the search box?
• If not, does the problem go away when you close and reopen the editor tab?
• If not, does the problem go away when you restart VS Code?

[alexdima]

Those highlights are not coming from the find widget (they would show in the overview ruler).

@Turash Can you please provide exact reproducible steps, we would love to get to the bottom of this issue.

[chrmarti]

@alexandrudima Wouldn't you expect the find widget to show the number of results instead of "No results"?

[ghost]

Hi,
I use the latest one for mac. I can never find the correct text at some point. I do not know if its for my cache memory. Should I sent you over my files or?

[alexdima]

@chrmarti Yes, there is something wrong (an event missing or ignored perhaps?) where the find widget in this case does not realize it gets a new model or something and does not research -- hence the lack of 'x of y' matches, the lack of find widget decorations, etc.

@Turash, sure we can start with the file that causes this issue, but is this happening all the time for you? As in, you open this specific file and cmd+f is never able to find anything in this file? Or is this happening after some certain steps, as in, you open a file, find in a file, then switch to a different file, etc.

I would love any hints on how we can reproduce, thank you.

[ghost]

Hi @alexandrudima
It happens after certain time. And no way back, but restart the ide.

[alexdima]

@Turash did you install extensions that modify and patch our sources (e.g. vscode-icons)?

[roblourens]

In case you guys didn't notice, 'find in selection' is selected in that screenshot. So there might be some selected text offscreen. I tend to trigger this on accident all the time. @Turash, next time can you try clicking that button in the find widget to the right of the arrows?

[alexdima]

@roblourens That is it! It is the find in selection.

@bgashler1 Should we emphasize somehow the find in selection toggle when there are no results and the toggle is on? The idea would be to bring attention to that toggle such that if you click it, you might get results in other areas of the file.

[bgashler1]

I've experienced this problem as well. It could definitely be improved. Whenever I have text selected that's on screen, it eventually sort of becomes clear to me what's going wrong. But if the selection is off screen this can be quite confusing.

I wonder if having this button enabled by default when there is a selection is the right thing to do. What is the reasoning behind having it automatically search within the selection only. I think it's pretty easy to not know that this will happen by default if there is a selection. Both Sublime and Atom require you to take an extra step to search only within a selection.

If we do leave this enabled by default we should make sure there is a good reason for doing so, and we should explore ways to alert users that this feature is enabled so they can understand why they're not getting what they may expect in a situation like above. Perhaps a different color of the "No results" and/or rename it to "No results in selection." Or perhaps the button that is enabled flashes or shakes. Or perhaps a dismissible overlay on the first instance of this problem that says "You are searching only within a selection. Turn this off to search the whole document"

[roblourens]

@alexandrudima @bgashler1 @chrmarti Could we make Find in Selection not enabled by default for October? One of my pet peeves.

[chrmarti]

It is enabled when selecting multiple lines in the editor before opening the find widget. We could turn off that behavior.

[roblourens]

Right, that's what I mean

[Bill-Stewart]

I think it makes sense not to enable the "Find in selection" option by default, especially as other editors have established this as a behavioral precedent. The current behavior is inconsistent (it only enables by default if the selection contains a newline). I also think the message should say "No results in selection" to make this more explicit.

[dvlsg]

This change definitely threw me off, since I am used to selecting multiple lines, pressing ctrl+f, searching, pressing shift+enter, then typing my replacements intended for the current selection.

Now that "find in selection" is no longer enabled by default when multiple lines are selected, I have to take my hands off the keyboard to go click that button, usually after I realize I just replaced way more than I originally intended.

I can certainly understand how the reverse could be irritating as well, though. Is there a currently available way to re-enable "find in selection" by default whenever more than one line is selected (config / setting), so we can choose for ourselves? Something like auto_find_in_selection in sublime text.

[bgashler1]

@dvlsg I don't think we have a setting for this. Could you create another issue requesting this (also reference this issue number in it)?

[Bill-Stewart]

My opinion: "Find in selection" should be enabled by default if there is any selection at all (multi-line or not). If "find in selection" is enabled by default only for certain kinds of selections, this seems arbitrary and inconsistent. For users that don't like "find in selection" to be enabled by default when there is a selection, it makes sense to have an option to disable it.

[dvlsg]

@bgashler1 I actually ran across #8843 after posting -- it's not quite the same, but that issue / request would be sufficient for me. I'm really just looking for a way to fire up the find-in-selection using just my keyboard.

If you think there might be sufficient desire for the explicit setting as well as the direct shortcut referenced in #8843, I certainly can take the time to create an issue request for that.

[bgashler1]

@Bill-Stewart we needed to remove the default find in selection behavior due to it being easy to misunderstand what was going on when no results were showing up for some users.

Two potential solutions we will consider are adding a setting to enable finding within selections by default or a new command as proposed in #8843 that you could rebind the keyboard shortcut for Find/Replace to that tries to find in selection by default.