Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsed markdown header doesn't expand when creating cell under it if cell is not active #122710

Closed
roblourens opened this issue Apr 30, 2021 · 3 comments
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook polish Cleanup and polish issue
Milestone

Comments

@roblourens
Copy link
Member

Related to #120641

Apr-29-2021.21-25-41.mp4

When I create a cell in an editor that isn't the active group, the markdown header parent is only expanded in the active group, not the one I clicked in.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook labels Apr 30, 2021
@roblourens roblourens self-assigned this Apr 30, 2021
@rebornix rebornix added this to the May 2021 milestone May 3, 2021
@rebornix rebornix modified the milestones: May 2021, June 2021 Jun 3, 2021
@rebornix rebornix added debt Code quality issues polish Cleanup and polish issue and removed bug Issue identified by VS Code Team member as probable bug labels Jun 3, 2021
@rebornix
Copy link
Member

rebornix commented Jun 3, 2021

It's a mix of two features:

  • click on insert toolbar will not steal focus
  • changes to no focused editor will not trigger relayout if possible (in this case, the left side editor only gets a model change, so no folding/collapse change

@roblourens roblourens modified the milestones: June 2021, Backlog Jul 1, 2021
@rebornix rebornix modified the milestones: Backlog, August 2021 Aug 4, 2021
@rebornix
Copy link
Member

rebornix commented Aug 4, 2021

The right behavior will be:

  • Clicking on the insert toolbar will focus the editor containing that toolbar
  • New cell inserted in the editor and folding region expaned
  • The other editor will not update

@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders notebook polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants
@roblourens @rebornix and others