-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments view should have ability to filter by resolved/unresolved #150958
Comments
Related: #142081 has some mocks for distinguishing unresolved comments better in the comments panel through icons and color. I believe at the moment, only the comment views in the code editor are colored differently? #127476 might be interesting to look at for designing the implementation, as it asked for more generic "tagging" of comment threads by the extensions that create them. I know that right now we only have resolved vs unresolved in the API, but it might make sense to keep the filtering logic slightly more generic in anticipation of more facets to filter by in the future (e.g. "only comment threads I am involved in, regardless of resolvedness" etc.). |
This is what the Problems view does (I clicked on the filter icon): Something like this will allow for #127476 too. If we add a For now though, I will add something similar to the filter menu in problems with "Show Resolved" and "Show Unresolved" options. |
Issue Type: Feature Request
In the Comments window, I see tons of comments on my PR, but I find it difficult to focus on the ones that are still open. There is a minor visual difference (blue/grey icon), but I would much rather have an ability to choose what is displayed (all/resolved/unresolved)
Extension version: 0.42.0
VS Code version: Code 1.67.2 (c3511e6, 2022-05-17T18:15:52.058Z)
OS version: Windows_NT x64 10.0.22621
Restricted Mode: No
Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2
Remote OS version: Linux x64 5.10.102.1-microsoft-standard-WSL2
The text was updated successfully, but these errors were encountered: