Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear passwords that don't decrypt #151654

Closed
TylerLeonhardt opened this issue Jun 9, 2022 · 2 comments · Fixed by #159506
Closed

Clear passwords that don't decrypt #151654

TylerLeonhardt opened this issue Jun 9, 2022 · 2 comments · Fixed by #159506
Assignees
@TylerLeonhardt
Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
September 2022

Comments

@TylerLeonhardt
Copy link
Member

If a password is not decrypted properly, then it should be removed from the secret storage because it's essentially dead.

Originally posted by @TylerLeonhardt in #147515 (comment)
@TylerLeonhardt TylerLeonhardt self-assigned this Jun 9, 2022
@TylerLeonhardt TylerLeonhardt added bug Issue identified by VS Code Team member as probable bug authentication Issues with the Authentication platform labels Jun 9, 2022
@TylerLeonhardt TylerLeonhardt added this to the July 2022 milestone Jun 9, 2022
@TylerLeonhardt TylerLeonhardt modified the milestones: July 2022, August 2022 Jul 29, 2022
This was referenced Aug 7, 2022
Merged
Closed
TylerLeonhardt added a commit that referenced this issue Aug 29, 2022
@TylerLeonhardt
Clear passwords that don't decrypt
765fd3b 
If a password is not decrypted properly, then it should be removed from the secret storage because it's essentially dead.

Fixes #151654
@TylerLeonhardt TylerLeonhardt mentioned this issue Aug 29, 2022
Merged
TylerLeonhardt added a commit that referenced this issue Aug 29, 2022
@TylerLeonhardt
Clear passwords that don't decrypt (#159506)
0d690b3 
If a password is not decrypted properly, then it should be removed from the secret storage because it's essentially dead.

Fixes #151654
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 29, 2022
@andreamah andreamah added the ~verification-steps-needed Steps to verify are needed (with bot comment) label Sep 29, 2022
@vscodenpa
Copy link

Friendly ping! Looks like this issue requires some further steps to be verified. Please provide us with the steps necessary to verify this issue.

@vscodenpa vscodenpa added verification-steps-needed Steps to verify are needed for verification and removed ~verification-steps-needed Steps to verify are needed (with bot comment) labels Sep 29, 2022
@TylerLeonhardt
Copy link
Member Author

Verification steps:

ping me if you have any questions or issues.

@TylerLeonhardt TylerLeonhardt removed the verification-steps-needed Steps to verify are needed for verification label Sep 29, 2022
@andreamah andreamah added the verified Verification succeeded label Sep 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@TylerLeonhardt TylerLeonhardt

Labels
authentication Issues with the Authentication platform bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
September 2022
3 participants
@TylerLeonhardt @andreamah @vscodenpa