Unable to write to settings should offer an action to open settings

[isidorn]

1. Have an error in your user settings
2. View > hide activity bar
3. Notice an error that we are unable to write to settings and that the user should fix them

This error should have an action to open settings as most users have a hard time finding settings.

[bpasero]

Also: we should try to be more aggressive in writing to the settings file if this happens from the default settings editor. A trailing comma for example should not block us from doing the write. Since you see the result of the operation and you can undo, we can be more relaxed and validate less imho.

[BobbyBabes]

@bpasero Thanks for the hint to the trailing comma.
Just upgraded to 1.8.0. It was a bit confusing why I couldn't change settings through the pencil icon, but could with a manual change followed by Ctrl+S.
Now the "... correct errors/warnings in the file ..." part of the error message makes more sense.

[sandy081]

Enhanced config editing service to be aggressive when writing to buffer.

• If writing directly to disk, it looks for all validations
• If writing to buffer, all errors are ignored while updating and saved if not dirty.

So when using actions inside Settings editor, its writes the configuration always. Since user see the editor this makes sense

[sandy081]

Config editing service was improved to be resilient with trailing commas. But all other errors are still valid and considered.

[sandy081]

All callees of configuration editing service are explicitly calling message service to show the message. This can be moved to config editing service to show message as an option.

[isidorn]

Reopening as I still get the same behavior as I described in my first comment

edit: args this item is not even closed and has verification needed 😕

[sandy081]

Its fine to have Verification needed tag even if it was not closed. But not sure how did it come verification list? The query should not contain any open items :)

[isidorn]

I have my own cool query which obviously failed in this case :)

[gregvanl]

I think we need to add a button to open settings when this error occurs as mentioned in the initial comment. It comes up often in doc feedback verbatim where users don't know where to go when a settings.json error occurs. Adding a button seems a good first step.

[gregvanl]

Adding @sandy081 to hopefully get this into the May milestone.