FindTextInFiles doesn't support comma-separated globs with {}

[andreamah]

Try extension with:

const disposable = vscode.commands.registerCommand('extension.helloWorld', async () => {
	const results: string[] = [];
	const glob = await vscode.window.showInputBox({ prompt: 'Glob pattern' });
	await vscode.workspace.findTextInFiles({ pattern: 'foo' }, {
		include: new vscode.RelativePattern(vscode.workspace.workspaceFolders![0], glob!),
	}, r => results.push(r.uri.toString()));
	vscode.window.showInformationMessage(JSON.stringify(results));
});

...and a workspace with files a/hello.txt and b/hello.txt both containing foo. Entering a glob for a/*.* or b/*.* will work, but {a/*.*,b/*.*} will return no results.

{a/*.*,b/*.*} is a valid glob and should work

[andreamah]

I believe that the main reason that this happens is because of a performance optimization that we make with text search here:

vscode/src/vs/workbench/services/search/node/ripgrepTextSearchEngine.ts

Line 498 in 6d0d2dc

function spreadGlobComponents(globArg: string): string[] {

We need to find a way to support {} (no nesting, since ripgrep doesn't support it) while keeping this optimization