-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UX for common notebook renderer performance issues #170309
Comments
Here are the results of our discussion: 2 Scenarios to focus on for now:
For file open, we currently warm up markdown renderers and their rendered output before rendering the notebook, this makes markdown cells stable on first load. However, for output cells, we do not warmup and the renderers can take any amount of time causing some amount of flicker on load. In order to reduce flicker, we propose allowing some small amount of time for warming up the outputs say up to 250ms. In performant cases, this will mean no flicker for the user. In other case, it will be the similar to today. In that case, it would be nice to measure and display the renderer time and allow users to see and report it. No ideas yet have been proposed on how to show this. For cell execution, there are several markers in time which we consider. The flow is as follows:
We are concerned with 2 timespans:
Our proposal is to detect when these times are above a threshold and indicate this to the user with a non-intrusive warning icon near the timer. Hovering this icon will reveal our stats and allow them to file an issue on the appropriate repo. |
First steps merged here #171888 |
Continuing the work started in #154873, @rebornix and I have identified a few common scenarios where we can smartly detect issues and direct the user to filing meaningful reports.
The text was updated successfully, but these errors were encountered: