Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native crash in macOS remote smoke tests #190854

Closed
bpasero opened this issue Aug 21, 2023 · 2 comments · Fixed by #197539
Closed

Native crash in macOS remote smoke tests #190854

bpasero opened this issue Aug 21, 2023 · 2 comments · Fixed by #197539
Assignees
@deepak1556
Labels
bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium fixed-in-electron-27 Issues fixed with Electron 27.x update freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed verified Verification succeeded
Milestone
December / Januar...

Comments

@bpasero
Copy link
Member

bpasero commented Aug 21, 2023

From: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=228258&view=results

566bc8db-1a99-4c33-b112-c433fd0a3edf.dmp.zip
@bpasero bpasero added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues macos Issues with VS Code on MAC/OS X smoke-test-failure labels Aug 21, 2023
@bpasero bpasero mentioned this issue Aug 21, 2023
Open
@deepak1556
Copy link
Collaborator

Refs https://bugs.chromium.org/p/chromium/issues/detail?id=1422170, seems to fixed in newer versions. Based on the timeline, https://chromium-review.googlesource.com/c/chromium/src/+/4633916 seems to be the candidate that addressed the issue.

I am hesitant to backport the change since it is not trivial, can look into it again if the number reports increases in the future.

@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) chromium Issues and items related to Chromium labels Aug 21, 2023
@deepak1556 deepak1556 added upstream-issue-fixed The underlying upstream issue has been fixed and removed smoke-test-failure labels Oct 9, 2023
@deepak1556 deepak1556 added the fixed-in-electron-27 Issues fixed with Electron 27.x update label Nov 30, 2023
@deepak1556 deepak1556 added this to the December 2023 milestone Nov 30, 2023
This was referenced Nov 30, 2023
Closed
Closed
@deepak1556 deepak1556 removed the macos Issues with VS Code on MAC/OS X label Nov 30, 2023
@deepak1556 deepak1556 mentioned this issue Dec 7, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2024
@bpasero bpasero added the verified Verification succeeded label Jan 23, 2024
@bpasero
Copy link
Member Author

bpasero commented Jan 23, 2024

I am not sure how to verify this but I will monitor again for new smoke test crashes if there are any crashes attached.

@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deepak1556 deepak1556

Labels
bug Issue identified by VS Code Team member as probable bug chromium Issues and items related to Chromium fixed-in-electron-27 Issues fixed with Electron 27.x update freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues insiders-released Patch has been released in VS Code Insiders upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-fixed The underlying upstream issue has been fixed verified Verification succeeded
Projects
None yet
Milestone
December / January 2024
Development

Successfully merging a pull request may close this issue.

chore: update to electron 27 microsoft/vscode
5 participants
@bpasero @deepak1556 @rzhao271 @aiday-mar @vscodenpa