Maximize Workbench Editor

[benibenj]

We want to allow users to not only maximize an editor group, but also the editor itself across the workbench.
I suggest to add the following command which can be added to the double click action of editor tabs:

Toggle Maximize Editor (Naming still open)

Double clicking the first time:

• Stores current state: visibility of Side Panels & Auxiliary Bar, ...
• Maximizes Editor Group
• Hides Side Panels & Auxiliary Bar

Double clicking the second time:

• Unmaximize Editor Group
• If the visibility of at least one panel/bar has been shown in the meantime:
  • Do not restore saved state
• If all panels are still hidden
  • Restore the visibility of the panels that were initially visible

[garretwilson]

As discussed in #16927, one major point is that this should happen wherever the focus is. If we are in the terminal, hitting the accelerator key will maximize the terminal (like Ctrl+Shift+J does now in VS Code on Windows). If you're in the editor, it maximizes the editor (similar but not completely like what Ctrl+B does in VS Code to hide the sidebar). If I'm in the sidebar (e.g. the file tree), the same keystroke maximizes the sidebar.

To see how this works, simply install Eclipse. In that IDE you can hit Ctrl+M to maximize and minimize whatever has the focus, whether it's the editor, a view at the bottom, the project explorer on the side, etc. That's what we were wanting in #16927.

Importantly, I should hit the same keystroke to go back to exactly the same "unmaximized" setting I was before—in other words, it remembers the size of the terminal, the editors, the sidebar, etc.

[dandavison]

Importantly, I should hit the same keystroke to go back to exactly the same "unmaximized" setting I was before—in other words, it remembers the size of the terminal, the editors, the sidebar, etc.

I agree that accurately remembering the previous editor configuration (splits) is essential.

If this work involves changes that are generally in the direction of being able to save and restore previous editor configurations that would be fantastic. It's something emacs does really well.

[starball5]

Related question on Stack Overflow: In VS Code, how can I toggle maximization of the current workbench part / editor group? where I have written up a workaround using editor group maximization and zen mode. It supports Editor groups and Panels.

[a-pav]

That's what we were wanting in #16927.

While I like to have what you (and this issue) propose, too, I also have to say that I'm genuinely satisfied with what is introduced in v1.84, So I hope it won't go away as a result of this issue :)

Been making noise in #109771, didn't know of #16927 until today.

(Edit: I realized that both of these issues have been assigned to the same person, so I shouldn't be worried as much.)