Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word filter for debug console #20838

Closed
nojvek opened this issue Feb 18, 2017 · 9 comments · Fixed by #102704
Closed

Word filter for debug console #20838

nojvek opened this issue Feb 18, 2017 · 9 comments · Fixed by #102704
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Milestone

Comments

@nojvek
Copy link
Contributor

nojvek commented Feb 18, 2017

image

image

Some sort of filter functionalaity like chrome devtools console or F12 console allowing one to filter errors/log/info would be nice. Being able to just see errors would drastically reduce signal to noise ratio when fixing unexpected js exceptions.

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Feb 21, 2017
@isidorn isidorn added this to the Backlog milestone Feb 21, 2017
@isidorn isidorn removed their assignment Feb 21, 2017
@adrum
Copy link

adrum commented Jun 8, 2017

Unless I'm missing it in the current version (1.12.2), it would be nice to be able to filter the debug console by words, along with log levels. This feature could've been inferred from the original post, but I wanted it to be explicitly mentioned as well.

@isidorn isidorn self-assigned this Oct 8, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 8, 2019

Currently you can Cmd/ctrl + F and start typing in the DEbug Console to filter. However we should make this more discoverable and somehow connect it to the verbosity to tackle this.

@chrissyast
Copy link

Currently you can Cmd/ctrl + F and start typing in the DEbug Console to filter. However we should make this more discoverable and somehow connect it to the verbosity to tackle this.

As far as I can tell, the filter in the Debug Console does not work properly.

For example, in the below image, there are no instances of the word 'foo', but searching 'foo' shows claims that there are 2 matches.

image

@JCKodel
Copy link

JCKodel commented Mar 30, 2020

Currently you can Cmd/ctrl + F and start typing in the DEbug Console to filter. However we should make this more discoverable and somehow connect it to the verbosity to tackle this.

Since when FIND is the same as FILTER?

A filter is something we DON'T want to show. A find is something we DO want to show.

For instance:
image

In 1 minute, there is thousands of those highlighted lines on my debug console. The red part is some error that has occurred. How can I filter using find when I don't know what will be printed on the console? How can I possible find every possible output, except the ones I want to filter?

We need a proper filter, specially:

  1. Be able to mark a line as debug, info, warning or error through regex (in my case, Flutter output is always W/ for warning, I/ for info, etc.) and filter by that
  2. Should be able to find only relevant entries (I want to see only entries that starts with or contains X, Y or Z)
  3. Should be able to filter irrelevant entries (I want to see all entries, except the ones that starts with or contains X, Y or Z)

@isidorn
Copy link
Contributor

isidorn commented Aug 21, 2020

We have added a filter to the debug console thanks to the PR #102704
For start this is a basic word filter. Error / log / info filter we would tackle as a seperate issue, so feel free to create an additional issue for that, or even better a new PR.
Thanks

@GitMensch
Copy link
Contributor

For start this is a basic word filter. Error / log / info filter we would tackle as a seperate issue, so feel free to create an additional issue for that

@isidorn While I really like the upcoming feature: this issues was specific about the "Error / log / info filter" as it is named "debug console needs to support error/log/info filters". The new very useful feature is related to this issue but doesn't fix it so I want to kindly ask you to either reopen it or rename it with a note "we track something related here as this is referenced all over the place now" and create the "new" (=original) issue referencing this one.

@isidorn
Copy link
Contributor

isidorn commented Sep 10, 2020

@GitMensch makes perfect sense, we already have an issue for this which we are currently discussing #105864

@GitMensch
Copy link
Contributor

Sounds good. I still would like to see this issue being renamed to specify what it is now about. Simplest one: "word filter for debug console".

@isidorn isidorn changed the title vscode debug console needs to support error/log/info filters Word filter for debug console Sep 10, 2020
@JCKodel
Copy link

JCKodel commented Sep 10, 2020

Sounds good. I still would like to see this issue being renamed to specify what it is now about. Simplest one: "word filter for debug console".

It's that hard to understand WE WANT A COPY OF ANDROID STUDIO'S FILTER?????

It is NOT "word search", it is a comprehensive RegEx filter to allow include or exclude expressions from that useless window.

How hard is to understand that? That's even a drawing on the first post... Can't be made simpler than that.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@JCKodel @nojvek @adrum @isidorn @GitMensch @chrissyast and others