-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't allow a before disallowed integrated terminal #23362
Comments
Any suggestions how to surface this without annoying the user? (how would disallow differ from cancel?) |
The problem here is that after a disallow the dialog doesn't show up anymore. So no way to trust the workspace later without using the dev tools and editing local storage |
@dbaeumer yes, the workarounds being moving the folder or changing local storage. The alternative is using user setting to drive this instead of local storage. Seems a bit messy doing that since paths generally aren't portable across machines and it's workspace-specific config in your user settings. Since the use case of a user re-enabling this at a later time seems to be so small I don't think it's worth changing this. The usage numbers for workspace shell's were really small when I looked at them so the chance that a user would choose to disallow and later make a conscious decision to allow seems really slim. Closing as designed for now, will listen for feedback. |
Strange. I was forced to do this for PHP :-). I simply added a context sensitive command to clear local storage. |
@dbaeumer maybe a command would be good, still not for this version. The multi-root discussion we're having at the moment may actually impact this. |
Steps to Reproduce:
"terminal.integrated.shell.windows": "C:\\WINDOWS\\Sysnative\\bash.exe"
Try to allow the shell. The only way I found is to use the dev tools and delete the key.
The text was updated successfully, but these errors were encountered: