Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Syntax Highlighting broken by method header on more than one line #36688

Closed
emilyeverett opened this issue Oct 21, 2017 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@emilyeverett
Copy link

  • VSCode Version: Code 1.14.2 (cb82feb, 2017-07-19T23:22:50.650Z)
  • OS Version: Darwin x64 16.7.0
  • Extensions:
Extension Author (truncated) Version
latex-workshop Jam 3.5.5
vscode-todo-highlight way 0.5.11

Steps to Reproduce:

Syntax highlighting is broken in the below code snippet:

public static <M extends Map<Integer, String>> 
boolean TestGet(Supplier<M> c) {
 //TODO write unit test for get
 //Setup
 Map<Integer, String> map = c.get();
 return false;
}

Highlighting is fixed if full method header is on the same line:

public static <M extends Map<Integer,String>> boolean TestGet(Supplier<M> c){
//TODO write unit test for get
//Setup
Map<Integer, String> map = c.get();
return false;
}

Reproduces without extensions: Yes

@snjeza
Copy link

snjeza commented Oct 22, 2017

@aeschli aeschli added this to the October 2017 milestone Oct 23, 2017
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Oct 23, 2017
@aeschli aeschli changed the title Syntax Highlighting broken by method header on more than one line [java] Syntax Highlighting broken by method header on more than one line Oct 25, 2017
@aeschli
Copy link
Contributor

aeschli commented Oct 25, 2017

I updated the Java grammar we use to the latest version from https:/atom/language-java.
The issue looks fixed to me:
image

@aeschli aeschli closed this as completed Oct 25, 2017
@snjeza
Copy link

snjeza commented Oct 25, 2017

@aeschli See #36786 (comment)

@mjbvz mjbvz added the verified Verification succeeded label Nov 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants