Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Split Terminal Font for Windows and OSX #48886

Closed
pingshunhuangalex opened this issue Apr 28, 2018 · 8 comments
Closed

[Feature Request] Split Terminal Font for Windows and OSX #48886

pingshunhuangalex opened this issue Apr 28, 2018 · 8 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues

Comments

@pingshunhuangalex
Copy link

Since it's much easier to have ZSH and Powerline terminal settings in OSX. I found myself using different fonts for my Mac and Windows. Also, some font name actually gets recognised differently on Windows and Mac machine, even using the same font file.

Right now, there is only one setting controlling the font of the terminal which I found rather inconvenient (terminal.integrated.fontFamily).

I propose we have OS related font family settings for terminal like:
terminal.integrated.fontFamily.windows and terminal.integrated.fontFamily.osx

Thanks.

@vscodebot
Copy link

vscodebot bot commented Apr 28, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Apr 28, 2018
@Tyriar
Copy link
Member

Tyriar commented Apr 28, 2018

I expect this problem to be solved eventually with #8962

@Tyriar Tyriar closed this as completed Apr 28, 2018
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 28, 2018
@specter119
Copy link

@Tyriar how to solve this with #8962?

@Tyriar
Copy link
Member

Tyriar commented May 14, 2018

Opps, wrong issue: #17619

@specter119
Copy link

@Tyriar I think we need support os-specific settings in settings.json rather than launch.json.
By the way, set "terminal.integrated.fontFamily" : "'font Mac', 'font Win', 'font Linux'" can work for all platforms, but "terminal.integrated.fontSize" is still unable to be defined properly on different platforms.

@Tyriar
Copy link
Member

Tyriar commented May 20, 2018

@specter119 Most of the latter comments are discussing it for settings.json.

@specter119
Copy link

@Tyriar

{
    "windows": {	
        "terminal.integrated.fontFamily": "Monokai",	
        "terminal.integrated.fontSize": 16,	
    },	
    "osx": {	
        "terminal.integrated.fontFamily": "Meslo LG S for Powerline",	
        "terminal.integrated.fontSize": 12	
    },	
    "linux": {	
        "terminal.integrated.fontFamily": "Noto Mono"	
    }
}

not work with all my devices. you can just try to change "terminal.integrated.fontSize" by this way.

@Tyriar
Copy link
Member

Tyriar commented May 21, 2018

@specter119 yes we should get a generic solution, rather than doing this for every single setting.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

3 participants