Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate to rewrite workbench layout using grid widget #50853

Closed
2 tasks done
bpasero opened this issue May 31, 2018 · 21 comments
Closed
2 tasks done

Investigate to rewrite workbench layout using grid widget #50853

bpasero opened this issue May 31, 2018 · 21 comments
Assignees
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues plan-item VS Code - planned item for upcoming
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 31, 2018

Given the introduction of the grid widget, we should explore to use it as the driver for the workbench layout, at least for the parts that are connected via sashes:

  • sidebar (left / right)
  • panel (bottom / right)
  • editor area

Related issues:

Grid widget prerequisites

  • allow to mark a specific view in the grid as the one to resize when the outer container grows (this is to make sure the editor area always increases in size if the window gets larger)
  • allow to "snap to hide" so that e.g. you can use the mouse to make the sidebar small enough that it hides and move back to show it again
@bpasero bpasero added debt Code quality issues layout General VS Code workbench layout issues labels May 31, 2018
@bpasero bpasero added this to the On Deck milestone May 31, 2018
@bpasero bpasero self-assigned this May 31, 2018
@bpasero
Copy link
Member Author

bpasero commented Jun 29, 2018

Some prerequisites for the grid widget before this can happen:

  • allow to mark a specific view in the grid as the one to resize when the outer container grows (this is to make sure the editor area always increases in size if the window gets larger)
  • allow to "snap to hide" so that e.g. you can use the mouse to make the sidebar small enough that it hides and move back to show it again

@bpasero bpasero modified the milestones: On Deck, October 2018 Oct 8, 2018
@bpasero bpasero added the plan-item VS Code - planned item for upcoming label Oct 8, 2018
@bpasero bpasero removed their assignment Oct 10, 2018
joaomoreno added a commit that referenced this issue Oct 24, 2018
joaomoreno added a commit that referenced this issue Oct 24, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Oct 25, 2018

Splitview now supports:

  • resize priorities, which allows to mark a specific view in the grid as the one to resize when the outer container grows
  • snap to hide

🎆

Another related commit: c01cf1d

@joaomoreno
Copy link
Member

joaomoreno commented Oct 25, 2018

Gridview now supports all of that too! 🎉 Getting closer

@bpasero
Copy link
Member Author

bpasero commented Oct 25, 2018

Awesome 👍

@joaomoreno joaomoreno removed their assignment Nov 5, 2018
@joaomoreno joaomoreno added feature-request Request for new features or functionality and removed debt Code quality issues labels Nov 5, 2018
@costincaraivan
Copy link
Contributor

This looks really cool, if it's what I think it is. One thing I'd be curious to know - would this include the possibility of having multiple terminal splits/sections as part of the grid?

That would enable some great workflows available when working in a terminal environment, but with the extra Visual Studio Code polish and better debugging experience.

Or does this include putting the whole panel in a split? Which definitely represents progress but doesn't get Visual Studio Code all the way to what I'm proposing 😃

@sbatten
Copy link
Member

sbatten commented Jan 24, 2019

@joaomoreno oooo will try this today

@joaomoreno
Copy link
Member

Didn't actually run it, so might not be complete, but you get the idea.

@dbaeumer
Copy link
Member

dbaeumer commented Feb 1, 2019

Moving to Feb.

@marcos-diaz
Copy link

Please note that ideal decoupling should not be just about choosing left/right position of the whole sidebar, but the ability of position each element in whatever panel the user wants, i.e. treeview at left, open files at right, and search at bottom... all at the same time!

@sbatten
Copy link
Member

sbatten commented Aug 29, 2019

closing this item as I believe we have tackled "investigation" :P

@sbatten sbatten closed this as completed Aug 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

9 participants