Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnClick event on Gutter #5455

Closed
alefragnani opened this issue Apr 18, 2016 · 28 comments
Closed

OnClick event on Gutter #5455

alefragnani opened this issue Apr 18, 2016 · 28 comments
Labels
api *duplicate Issue identified as a duplicate of another issue(s) editor-api Issues about the API of vscode in the area of editors feature-request Request for new features or functionality

Comments

@alefragnani
Copy link

How could I handle OnClick events on Gutter, similar to how breakpoints does?

The intention was to connect it with a decorator (previously created with vscode.window.createTextEditorDecorationType) so the user should Click on the Gutter and create/destroy the decorator assigned to the line where the user clicked.

Thanks in advance

@AnneTheAgile
Copy link

AnneTheAgile commented Oct 31, 2018

Cross refs;
1.This, Right click in vscode edge, mentioned: "visual studio code - Add right click menu item inside gutter of vscode" - Stack Overflow ; ; https://stackoverflow.com/questions/41821174/add-right-click-menu-item-inside-gutter-of-vscode
2.Right click on file in Opsys ;
Add shortcut for file right click context menu. #15939
3.Right click in editor:
Custom menu entires, context menu entries, and action bar items #3192
3.1.Within the bgse/relative-path-and-line extension , their first request;
Feature Request: add actions to context menu #1
4.Click in Menu Bar of editor; this appears to be the item merged as a result of [3]
menu bar extensions #7704

@ThisIsABug
Copy link

@AnneTheAgile just for clarification: the origin of this feature request wasn't the possibility to expose a whole context menu, this is already working some pixels to the right of the gutter. So the user has a very similar possibility already.
The origin was here: alefragnani/vscode-bookmarks#24
It is just about the mentioned decorator. It is about a single left-click feature like toggling a breakpoint.

@sguillia
Copy link

sguillia commented Feb 7, 2020

There now is an onclick event on the gutter, when editing settings.json.

It doesn't seem exposed through the API though.

Capture du 2020-02-07 12-24-41

@sketchbuch
Copy link

This would be really useful. Any information about if this will happen? I'm making an extension where I want to click on a gutter icon that my extension creates and run a command and/or show a drop down menu.

@sudhagar10
Copy link

I started working on an extension assuming this was already exposed and now I am stuck.

I got misled by breakpoint and the edit icon appearing in the gutter of settings page.

@chakraborty-slx
Copy link

@sudhagar10
Copy link

sudhagar10 commented May 4, 2020

@sudhagar10 can you check this https://marketplace.visualstudio.com/items?itemName=ryanluker.vscode-coverage-gutters

Thanks @chakraborty-slx. Took a look at it.

I was able to place icons in gutter. But click event there is not exposed and that is where I am stuck.

@Almenon
Copy link

Almenon commented Jul 4, 2020

onHover would be useful too. For example in AREPL it would be cool if the user could hover over the error icon in the gutter to see the full exception message.

(commenting on this issue instead of a new one because I'm assuming it would be easy to add a onHover event along with onClick)

@canadaduane
Copy link

Has anyone begun working on this?

@helviett
Copy link

It would be a nice feature to have!

@ffMathy
Copy link

ffMathy commented Nov 26, 2020

I would love this too!

@eamodio
Copy link
Contributor

eamodio commented Jan 5, 2021

FYI, this issue is related to #47559

@luispDesktop
Copy link

It would be great to have this ability. Bump for this!
It greatly increases the ability to have options from icons showing in the gutter.

@alexdima alexdima added editor-rendering Editor rendering issues editor-api Issues about the API of vscode in the area of editors and removed editor editor-rendering Editor rendering issues labels Oct 15, 2021
@nickzhums
Copy link
Member

The Java team would also like to see this feature supported, as we are exploring various UX improvement to our Java & Spring extensions. It seems that this is an established UX behavior in Java IDEs and one of the user asks from our survey. If we can support not just click events to the icons next to the line numbers, but also expose some kind of menu (like current testing API), it would be awesome.

@rebmcr
Copy link

rebmcr commented Feb 22, 2022

I want to be able to click the line number to make a bookmark — just like I have been able to do in Notepad++ for the past fifteen years.

@dennispi
Copy link

dennispi commented Apr 18, 2022

We're also seeing usability issues with our user testing and the existing interaction model.

Currently, users need to:

  • hover over our extension's gutter icon
  • observe the tooltip
  • very carefully navigate over to the tooltip
  • very carefully click on the Title on the tooltip
  • begin interaction

This is much easier to understand when you see it:
CleanShot 2022-04-18 at 11 56 21

What they're expecting:

  • click the gutter icon
  • (extension opens webview)
  • user begins interaction

I the expectation is based on experience with breakpoints. Developers are conditioned to view a gutter icon, click on it, and take action.

We'd be happy to implement this as it seems to be a popular request from a number of extension authors (133 upvotes as of this comment).

@aldanchenko
Copy link

Hi all 👋

I'm correctly understood that this function is still not implemented?

@alefragnani
Copy link
Author

@aldanchenko , you are right. It isn't available yet...

@aldanchenko
Copy link

I see. Thanks @alefragnani!

@weirane
Copy link

weirane commented Mar 2, 2023

This is much easier to understand when you see it: CleanShot 2022-04-18 at 11 56 21

@dennispi May I ask what extension is this in the GIF? I'm trying to add hover messages on the gutter decoration but can't figure out how to do it. I think it'll be helpful to see how this extension does it.

@joyceerhl
Copy link
Contributor

@alefragnani @nickzhums FYI, relatedly there's an API proposal to expose a context menu in the editor gutter #175945 in order to support copying links for a line or range. You can try it out in the latest insiders but it'll only work in development until finalization. Any feedback is appreciated.

@alefragnani
Copy link
Author

@joyceerhl thanks for pointing that out! I'll definitely take a look, and let you know how to fit on my scenarios 👍

@alefragnani
Copy link
Author

Hi @joyceerhl ,

I would say, at least on my side, that this issue can be closed as completed. 🎉

As I commented on the API Proposal (#175945 (comment)), the API worked perfectly. And I'm already using on my extensions.

Thank you!

@joyceerhl joyceerhl removed this from the Backlog milestone Dec 6, 2023
@joyceerhl joyceerhl added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 6, 2023
@mcoblenz
Copy link

mcoblenz commented Dec 6, 2023

I'm not sure that a context menu suffices for our purposes. Can I make it so clicking an icon causes an action? Or must the icon open a context menu?

@mcoblenz
Copy link

mcoblenz commented Dec 6, 2023

I'm not sure that a context menu suffices for our purposes. Can I make it so clicking an icon causes an action? Or must the icon open a context menu?

(see https://marketplace.visualstudio.com/items?itemName=Kale-Lab.salt for the use case)

@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) editor-api Issues about the API of vscode in the area of editors feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests