Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve signature help rendering #55629

Closed
DanTup opened this issue Aug 2, 2018 · 5 comments
Closed

Improve signature help rendering #55629

DanTup opened this issue Aug 2, 2018 · 5 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-parameter-hints Function, method and class parameter hint widget feature-request Request for new features or functionality
Milestone
Backlog

Comments

@DanTup
Copy link
Contributor

DanTup commented Aug 2, 2018

The signature help provider seems to insert newlines that didn't exist in the source (for ex after WidgetBuilder> {} in this code):

screen shot 2018-08-02 at 8 49 59 am

There are no newlines in the source string:

screen shot 2018-08-02 at 8 50 37 am
@DanTup
Copy link
Contributor Author

DanTup commented Aug 2, 2018

Also, if I do put newlines in the source, they get ignored. Not sure if that's intended (the lack of colours make this really difficult to read, so newlines might've been a good compromise).

@jrieken jrieken assigned joaomoreno and unassigned jrieken Aug 6, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Aug 6, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug editor-parameter-hints Function, method and class parameter hint widget labels Aug 6, 2018
@joaomoreno joaomoreno added feature-request Request for new features or functionality bug Issue identified by VS Code Team member as probable bug and removed bug Issue identified by VS Code Team member as probable bug feature-request Request for new features or functionality labels Sep 19, 2018
@joaomoreno joaomoreno changed the title Signature help renders newlines in label that were not there in source Improve signature help rendering Sep 19, 2018
@joaomoreno joaomoreno added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Sep 19, 2018
@joaomoreno
Copy link
Member

Currently, we render everything as wrappable monospace font. Needs better support.

@joaomoreno joaomoreno removed their assignment Sep 19, 2018
@ramya-rao-a
Copy link
Contributor

@joaomoreno Isnt #50813 referring to something similar? We can keep only one of the 2 for tracking purposes?

@joaomoreno
Copy link
Member

/duplicate #50813

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 3, 2018
@vscodebot
Copy link

vscodebot bot commented Oct 3, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Oct 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-parameter-hints Function, method and class parameter hint widget feature-request Request for new features or functionality
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@joaomoreno @DanTup @jrieken @ramya-rao-a