Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core services from main back into shell #6093

Closed
bpasero opened this issue May 4, 2016 · 7 comments
Closed

Move core services from main back into shell #6093

bpasero opened this issue May 4, 2016 · 7 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 4, 2016

It is bad that we only have it outside shell because we need to initialize it, instead we should load the config and pass it into the shell and construct the config service in there how it used to be.

@bpasero bpasero self-assigned this May 4, 2016
@bpasero bpasero added the debt Code quality issues label May 4, 2016
@bpasero bpasero added this to the Backlog milestone May 4, 2016
@bpasero
Copy link
Member Author

bpasero commented May 4, 2016

@joaomoreno cc

@joaomoreno
Copy link
Member

joaomoreno commented May 4, 2016

Another idea would be to make the get return a Promise. This, to me, would be much cleaner.

cc @jrieken

@bpasero
Copy link
Member Author

bpasero commented May 4, 2016

So you say making it possible to set a Promise<IService> into the collection that gets resolved?

@jrieken
Copy link
Member

jrieken commented May 6, 2016

Another idea would be to make the get return a Promise. This, to me, would be much cleaner.

unsure what that means?

@joaomoreno
Copy link
Member

Nah. Make the get method of the configuration service be async.

@jrieken
Copy link
Member

jrieken commented May 24, 2016

You mean this get-method? We only recently made it sync ;-)

@bpasero bpasero modified the milestones: August 2016, Backlog Aug 16, 2016
@bpasero bpasero changed the title IConfigurationService should move back into shell Move core services from main back into shell Aug 23, 2016
@bpasero
Copy link
Member Author

bpasero commented Apr 19, 2017

Closing (clean up), no plans to work on this.

@bpasero bpasero closed this as completed Apr 19, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

3 participants