Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IWorkspaceContextService should only exist on renderer side and have less functionality #6095

Closed
bpasero opened this issue May 4, 2016 · 2 comments
Closed

IWorkspaceContextService should only exist on renderer side and have less functionality #6095

bpasero opened this issue May 4, 2016 · 2 comments
Assignees
@bpasero
Labels
debt Code quality issues
Milestone
August 2016

Comments

@bpasero
Copy link
Member

bpasero commented May 4, 2016

We should split this guy up into pieces and only leave the workspace specific functionality.
@bpasero bpasero self-assigned this May 4, 2016
@bpasero bpasero added the debt Code quality issues label May 4, 2016
@bpasero bpasero added this to the Backlog milestone May 4, 2016
@bpasero
Copy link
Member Author

bpasero commented May 4, 2016

@joaomoreno cc

This was referenced Jul 5, 2016
Closed
Closed
bpasero added a commit that referenced this issue Aug 16, 2016
@bpasero
introduce and use IEnvironmentService to the renderer (for #6095)
d54054e
@bpasero bpasero modified the milestones: August 2016, Backlog Aug 16, 2016
@bpasero
Copy link
Member Author

bpasero commented Aug 18, 2016

Lots of work has happened and there are only a few places left where the old LegacyContextService is being used. This will be continued in other issues, closing.

@bpasero bpasero closed this as completed Aug 18, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues
Projects
None yet
Milestone
August 2016
Development

No branches or pull requests
1 participant
@bpasero