Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar pushed out of view when window is very small #6810

Closed
isidorn opened this issue May 24, 2016 · 5 comments
Closed

Sidebar pushed out of view when window is very small #6810

isidorn opened this issue May 24, 2016 · 5 comments
Assignees
@isidorn
Labels
layout General VS Code workbench layout issues

Comments

@isidorn
Copy link
Contributor

isidorn commented May 24, 2016

  • VSCode Version: alpha
  • OS Version: OS X

Steps to Reproduce:

  1. open vscode, do not have it full screen, have it just occupy a portion of the screen
  2. open developer tools
  3. open editors side by side -> layout get broken due to limited size

As you pointed out wokrbench is not aware that the developer tools got opened and thus the layout gets broken.

screen shot 2016-05-24 at 15 48 14
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug workbench labels May 24, 2016
@bpasero
Copy link
Member

bpasero commented May 24, 2016

This is likely because I am not aware of the fact that developer tools steel vertical space from me.

@bpasero bpasero added this to the June 2016 milestone May 24, 2016
@bpasero
Copy link
Member

bpasero commented May 25, 2016

Reproduces in stable already.

@bpasero bpasero modified the milestones: Backlog, June 2016 May 25, 2016
@bpasero bpasero changed the title Developer tools can break workbench layout Sidebar pushed out of view when window is very small May 31, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label May 31, 2016
@bpasero
Copy link
Member

bpasero commented May 31, 2016

Behaves like this since our initial release actually.

@bpasero bpasero removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 31, 2016
@bpasero bpasero added the help wanted Issues identified as good community contribution opportunities label Oct 4, 2016
@bpasero bpasero mentioned this issue Oct 27, 2016
Closed
bpasero added a commit that referenced this issue Oct 31, 2016
@bpasero
make #6810 a little bit better
fee0c0f
@bpasero bpasero assigned isidorn and unassigned bpasero Nov 15, 2017
@bpasero bpasero removed the help wanted Issues identified as good community contribution opportunities label Nov 15, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 15, 2017
@bpasero
Copy link
Member

bpasero commented Nov 15, 2017

Not sure this still happens with all the layout changes. But also feel free to close.

@bpasero bpasero closed this as completed Nov 15, 2017
@bpasero bpasero added layout General VS Code workbench layout issues and removed workbench labels Nov 15, 2017
@isidorn
Copy link
Contributor Author

isidorn commented Nov 15, 2017

Of course my awesome changes fixed this :D

@isidorn isidorn removed the bug Issue identified by VS Code Team member as probable bug label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
layout General VS Code workbench layout issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpasero @isidorn