Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: dynamic debug configurations #95837

Closed
2 tasks done
isidorn opened this issue Apr 22, 2020 · 3 comments
Closed
2 tasks done

Test: dynamic debug configurations #95837

isidorn opened this issue Apr 22, 2020 · 3 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 22, 2020

Refs: #95835, #88230

Complexity: 3

Authors: @weinand, @isidorn


We now support dynamic debug configurations, that means an extension can contribute dynamically created debug configurations to places where only the static debug configurations from the launch.json were shown previously.

Develop an extension that uses the new API or modify an existing debug extension to use the new API and verify the following:

  • the extension API for dynamic debug configs works as specified
  • When invoking the "Select and Start Debugging" command, you are presented with a "dynamic debug configuration container" for your extensions.
  • This container item is decorated with a folder icon, is in a separate group and once you choose it you can see a list of dynamic debug configurations which just got resolved
  • Once you choose a configuration, debug is started
  • The same container for dynamic debug configurations appears in the debug viewlet's dropdown menu (but it does not have an icon for technical reasons).
  • Once you start debugging and the chosen option is the container, you can choose a configuration and start debugging.

Feedback on the whole flow is very welcome:
@connor4312 @RMacfarlane do you like the behavior of the container item in the debug viewlet's drop down menu? After selecting it nothing happens but you have to press the play button to actually make a selection. The alternative interaction would be to open the quickpick immediately when selecting the container item.

@RMacfarlane
Copy link
Contributor

I felt ok about having the quickpick shown when you press the play button, it didn't bother me. But I think the alternative of showing the quickpick immediately would be better - that way if I repeatedly stop and start debugging, I don't have to keep making the same selection.

@RMacfarlane RMacfarlane removed their assignment Apr 29, 2020
@weinand
Copy link
Contributor

weinand commented Apr 29, 2020

@isidorn pls see Rachel's comment

@isidorn
Copy link
Contributor Author

isidorn commented Apr 30, 2020

@RMacfarlane makes sense. Please file a new feature request for this, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

4 participants