Updates tsec and rewrites sinks assignement #112069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the bug where tsec was not running a postinstall build, which caused it to keep running an old version. This new version comes with new violations and Trusted Types awareness. Also pins tsec to the latest commit so that the version fetched is always the same.
Moves the casts to the sink assignement expression so that tsec can recognize it.
|
|
|
Thanks @engelsdamien! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest tsec commit fixes a bug where tsec was no building properly postinstall, this PR updates tsec to the latest commit and pins it to that commit in
package.json.This PR also rewrites policy usages to all be of the same shape (i.e.
policy?.createHTML(html) ?? html) and moves all the casts to the sinks assignment expressions directly as this is the only way tsec can recognize them.This PR fixes #111289
Related issues are #108400 #103699 & google/tsec#18