Switch to dompurify for sanitizing markdown content #131950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Assigning: @jrieken For trusted types |
alexr00
approved these changes
Aug 31, 2021
jrieken
approved these changes
Aug 31, 2021
| return removeEmbeddedSVGs(raw); | ||
| const x = sanitize(raw); | ||
| console.log(raw); | ||
| console.log(x); |
mjbvz
force-pushed
the
dev/mjbvz/dompurify
branch
from
e39ca04
to
053257e
Compare
|
@jrieken Any idea on why I now get the eslint error in The code looks like: Where We were previously assigning to |
@mjbvz fd122aa isn't the best way to tackle this. A special sequence of casts is needed here... |
Switches us from using `insane` to instead use `dompurify`, which seems to be better maintained and also has some nice features, such as built-in trusted types support I've tried to port over our existing sanitizer settings as best as possible, but there's not always a 1:1 mapping between how insane works and how dompurify does. I'd like to get this change in early in the iteration to catch potential regressions
innerHTML can return different results on different browsers. Use `isEqualNode` instead
mjbvz
force-pushed
the
dev/mjbvz/dompurify
branch
from
a6cc048
to
53de038
Compare
mjbvz
force-pushed
the
dev/mjbvz/dompurify
branch
from
052818f
to
f8bd73f
Compare
I beleive this is required since we allow links to commands and loading images over remote
mjbvz
added a commit
that referenced
this pull request
Sep 3, 2021
Fixes #40607 This change introduces a new `supportsHtml` property on `MarkdownString` that can be used to enable rendering of a safe subset of tags and attributes inside of markdown strings For backwards compatability, `supportsHtml` will default to false and must be explicitly enabled by extensions This PR will need to go in after we adopt dompurify (#131950) which should provide better control over how we actually go about sanitizing rendered html
|
Thanks everyone! Merging in to get testing in insiders to catch potential regressions |
mjbvz
added a commit
that referenced
this pull request
Sep 3, 2021
Fixes #40607 This change introduces a new `supportsHtml` property on `MarkdownString` that can be used to enable rendering of a safe subset of tags and attributes inside of markdown strings For backwards compatibility, `supportsHtml` will default to false and must be explicitly enabled by extensions This PR will need to go in after we adopt dompurify (#131950) which should provide better control over how we actually go about sanitizing rendered html
mjbvz
added a commit
that referenced
this pull request
Sep 3, 2021
Fixes #40607 This change introduces a new `supportsHtml` property on `MarkdownString` that can be used to enable rendering of a safe subset of tags and attributes inside of markdown strings For backwards compatibility, `supportsHtml` will default to false and must be explicitly enabled by extensions This PR will need to go in after we adopt dompurify (#131950) which should provide better control over how we actually go about sanitizing rendered html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches us from using
insaneto instead usedompurify, which seems to be better maintained and also has some nice features, such as built-in trusted types supportI've tried to port over our existing sanitizer settings as best as possible, but there's not always a 1:1 mapping between how insane works and how dompurify does. I'd like to get this change in early in the iteration to catch potential regressions