Fix race condition between setDecorations and edit #172672
Draft
+43
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this one? It's been sitting open for a while and I'd love some feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74094
This PR is a quick sketch of an approach to solve the race condition in #74094. It borrows the version checking from
applyEditCould alternately allow the caller (extension developer) to supply the document version number, but I think this version should solve the problem, potentially if the caller does their own additional version check against the version known to the extension host
I still need to update the interfaces and potentially add some tests, but figured I'd throw something quick together to start the conversation