Adding keyboard control for navigation through sticky scroll lines #174670

aiday-mar · 2023-02-17T11:08:19Z

Fixes #169107.

Code has been added to enable the user to navigate through the sticky scroll lines.

It is possible to navigate through the sticky lines with the Up and Down arrows. To jump to a sticky line use Enter.
Focus Sticky Scroll is only available when Sticky Scroll is enabled.
The sticky scroll hover can work simultaneously with the focus
When scrolling, this disables the sticky scroll focus
This pull-request contains additional refactoring that was done to make the code cleaner.

…used

…roll so that the focus is removed when hoverin with the mouse

…n in sticky scroll focus mode

…ller

…make several instances

…racker

…ch it was previously hovered on if hovered with the mouse

src/vs/editor/contrib/stickyScroll/browser/stickyScrollActions.ts

src/vs/editor/contrib/stickyScroll/browser/stickyScrollController.ts

src/vs/editor/contrib/stickyScroll/browser/stickyScroll.css

…stciky scroll widget

… line

aiday-mar added 15 commits February 16, 2023 10:01

work in progress

eb72100

added code in order to make individual sticky lines grey

20cc79c

adding changes

f931df6

Adding code in order to have context keys

badba6f

changing the code

49df40b

adding code in order not to move the cursor when sticky scroll is foc…

7881f8c

…used

Simplifying the code

2df6275

removing unecessary code

520b67e

converting to an arrow function in order to avoid error

b4191bc

removing a console log

b1b4dd8

removing the stickyScrollLinesEnabled boolean

1317642

removing a comment

ccc0603

removing space

f7d61a6

settig back tasks.json to what it was

6fdf23e

saving the default tasks.json

eedbcda

vscodenpa assigned aiday-mar Feb 17, 2023

aiday-mar added 8 commits February 17, 2023 14:02

Cleaned the code and also added an on hover listener on the sticky sc…

ee51d0b

…roll so that the focus is removed when hoverin with the mouse

removing a useless variable

425f9fa

when clicking on escape comming out of the focus

3e06bc3

writing out all the classes as interfaces

3ef249e

Changed the left arrow to an Enter key code

7e4d695

Merge branch 'main' into aiday/issue169107

25b143e

also preventing the user from typing on the left and on the right whe…

2675b8c

…n in sticky scroll focus mode

added back the css for when the sticky scroll widget is focused

89bbb96

aiday-mar requested a review from alexdima February 17, 2023 15:56

aiday-mar marked this pull request as ready for review February 17, 2023 15:57

vscodenpa added this to the February 2023 milestone Feb 17, 2023

instead of using notEqualsTo(true) use isEqualTo(false)

35a1d39

aiday-mar requested a review from jrieken February 20, 2023 10:11

aiday-mar removed this from the February 2023 milestone Feb 20, 2023

aiday-mar added this to the March 2023 milestone Feb 20, 2023

aiday-mar added 9 commits February 20, 2023 15:50

removing the dependence on the context key

344be96

removed the servcice

df04e7b

making the sticky scroll focused context key a property of the contro…

048a71d

…ller

assigning the context key to a property of the class in order to not …

b4f59bf

…make several instances

adding some changes

9aa0aef

added some console messages in order to better understand the focus t…

2e4540f

…racker

adding code to the widget so that it remembers the sticky line on whi…

476a144

…ch it was previously hovered on if hovered with the mouse

work in progress

26616be

refactoring the code and using the focus tracker

40f6279

jrieken reviewed Feb 28, 2023

View reviewed changes

aiday-mar added 11 commits February 28, 2023 12:45

renamed toggle focus sticky scroll to focus sticky scroll

1d8625b

removing the keybindings

dc79c61

adding the ondidfocus listener on the focus tracker

b444d6d

adding changes from review

6f3a796

adding changes from review

f8bb5c8

adding last changes

8994c08

setting the attribute to be a list for the root dom node

19ebffa

removed the unecessary call to blur()

150e817

adding changes so that the focus persist on the scrolling

ad7d621

making line number distinction before and after the rendering of the …

3dfcc87

…stciky scroll widget

removing unecessary code

d3086e5

aiday-mar requested a review from jrieken February 28, 2023 18:47

disposing when clicking on the sticky scroll and revealing some other…

96a563d

… line

jrieken approved these changes Mar 1, 2023

View reviewed changes

jrieken requested review from jrieken and removed request for alexdima March 1, 2023 10:28

aiday-mar merged commit 4d6e189 into main Mar 1, 2023

aiday-mar deleted the aiday/issue169107 branch March 1, 2023 12:02

github-actions bot locked and limited conversation to collaborators Apr 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding keyboard control for navigation through sticky scroll lines #174670

Adding keyboard control for navigation through sticky scroll lines #174670

aiday-mar commented Feb 17, 2023 •

edited

Loading

Adding keyboard control for navigation through sticky scroll lines #174670

Adding keyboard control for navigation through sticky scroll lines #174670

Conversation

aiday-mar commented Feb 17, 2023 • edited Loading

aiday-mar commented Feb 17, 2023 •

edited

Loading