Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proposed explorer/context/share and editor/title/context/share menus #175688

Merged
merged 3 commits into from
Feb 28, 2023
Merged

Add proposed explorer/context/share and editor/title/context/share menus #175688

merged 3 commits into from
Feb 28, 2023

Conversation

joyceerhl
Copy link
Contributor

For #175676

@joyceerhl joyceerhl self-assigned this Feb 28, 2023
@joyceerhl joyceerhl enabled auto-merge (squash) February 28, 2023 18:58
@vscodenpa vscodenpa added this to the March 2023 milestone Feb 28, 2023
@connor4312
Copy link
Member 

[tsec-compile-check      ] src/vs/workbench/browser/parts/editor/editor.contribution.ts(356,36): error TS2339: Property 'EditorTabsBarContext' does not exist on type 'typeof MenuId'.
[tsec-compile-check      ] src/vs/workbench/browser/parts/editor/editor.contribution.ts(357,36): error TS2339: Property 'EditorTabsBarContext' does not exist on type 'typeof MenuId'.
[tsec-compile-check      ] src/vs/workbench/browser/parts/editor/editor.contribution.ts(358,36): error TS2339: Property 'EditorTabsBarContext' does not exist on type 'typeof MenuId'.
[tsec-compile-check      ] src/vs/workbench/browser/parts/editor/editor.contribution.ts(359,36): error TS2339: Property 'EditorTabsBarContext' does not exist on type 'typeof MenuId'.
[tsec-compile-check      ] src/vs/workbench/browser/parts/editor/editor.contribution.ts(360,36): error TS2339: Property 'EditorTabsBarContext' does not exist on type 'typeof MenuId'.
[tsec-compile-check      ] src/vs/workbench/browser/parts/editor/tabsTitleControl.ts(418,20): error TS2339: Property 'EditorTabsBarContext' does not exist on type 'typeof MenuId'.
[tsec-compile-check      ] src/vs/workbench/contrib/files/browser/fileActions.contribution.ts(588,62): error TS2339: Property 'EditorTabsBarContext' does not exist on type 'typeof MenuId'.
[tsec-compile-check      ] 
[tsec-compile-check      ] 
[tsec-compile-check      ] Found 7 errors.

connor4312
connor4312 previously approved these changes Feb 28, 2023
View reviewed changes
@joyceerhl joyceerhl merged commit befa72b into main Feb 28, 2023
@joyceerhl joyceerhl deleted the dev/joyceerhl/ancient-flyingfish branch February 28, 2023 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aeschli aeschli aeschli approved these changes

@connor4312 connor4312 connor4312 left review comments

Assignees

@joyceerhl joyceerhl

Labels
None yet
Projects
None yet
Milestone
March 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@joyceerhl @connor4312 @aeschli @vscodenpa